From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gamin: fix build with musl
Date: Wed, 30 Mar 2016 00:05:18 +0200 [thread overview]
Message-ID: <20160330000518.22043b3d@free-electrons.com> (raw)
In-Reply-To: <d03fac44ed52ad7fe05fdd1bb6040a260cfc14b7.1456837391.git.baruch@tkos.co.il>
Hello,
On Tue, 1 Mar 2016 15:03:11 +0200, Baruch Siach wrote:
> musl does not provide the non portable PTHREAD_MUTEX_RECURSIVE_NP. Add a patch
> removing the assumption the PTHREAD_MUTEX_RECURSIVE_NP is available when
> 'linux' is defined.
>
> Upstream had no new release since 2008, so there is no much hope of getting
> this fix applied upstream.
Not quite true :) If you check https://git.gnome.org/browse/gamin/log/,
there has been a commit in early February 2016. Granted, it was the
first commit since almost two years, but still. It's worth submitting
upstream :-)
> Also, fix the pthread dependency comment. gamin code uses pthread directly.
>
> Fixes:
> http://autobuild.buildroot.net/results/3a9/3a9328f384fc648ae61316402a84eaffb175881b/
> http://autobuild.buildroot.net/results/69d/69d2a93bc97ab0d70c3acb2f9c9f28612ea95871/
> http://autobuild.buildroot.net/results/092/092ac7380beb8ce403a1a6fd8e4176e9234413a3/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ...0003-fix-missing-PTHREAD_MUTEX_RECURSIVE_NP.patch | 20 ++++++++++++++++++++
> package/gamin/Config.in | 2 +-
> 2 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 package/gamin/0003-fix-missing-PTHREAD_MUTEX_RECURSIVE_NP.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-29 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 13:03 [Buildroot] [PATCH] gamin: fix build with musl Baruch Siach
2016-03-29 22:05 ` Thomas Petazzoni [this message]
2016-04-01 8:49 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330000518.22043b3d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox