Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] aer-inject: new package
Date: Wed, 30 Mar 2016 18:26:53 +0200	[thread overview]
Message-ID: <20160330182653.6d1791c0@free-electrons.com> (raw)
In-Reply-To: <1459342912-10816-1-git-send-email-tiago.brusamarello@datacom.ind.br>

Hello,

I've applied your patch, after doing a few tweaks.

First of all, could you fix your SMTP configuration so that your From:
is Tiago Brusamarello <...> rather than tiago.brusamarello ?

On Wed, 30 Mar 2016 10:01:52 -0300, tiago.brusamarello wrote:
> aer-inject allows to inject PCIE AER errors on the software level into
> a running Linux kernel. This is intended for validation of the PCIE
> driver error recovery handler and PCIE AER core handler.
> 
> Change-Id: Id3e701a9eb692627db42320ea7c37afbf4f712b8

This line is not needed.

> Signed-off-by: tiago.brusamarello <tiago.brusamarello@datacom.ind.br>

This should also be Tiago Brusamarello <....>

> diff --git a/package/aer-inject/Config.in b/package/aer-inject/Config.in
> new file mode 100644
> index 0000000..8856ff1
> --- /dev/null
> +++ b/package/aer-inject/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_AER_INJECT
> +	bool "aer-inject"
> +	help
> +	  aer-inject allows to inject PCIE AER errors on the software level into
> +	  a running Linux kernel. This is intended for validation of the PCIE
> +	  driver error recovery handler and PCIE AER core handler.
> +
> +	  Requires a new Linux kernel with PCIE AER error injection patches.

Those lines were slightly too long, so I rewrapped them.

> +AER_INJECT_VERSION = 9bd5e2c7886fca72f139cd8402488a2235957d41
> +AER_INJECT_SITE = git://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git
> +AER_INJECT_SITE_METHOD = git
> +AER_INJECT_LICENSE = GPLv2
> +AER_INJECT_LICENSE_FILES = README
> +AER_INJECT_DEPENDENCIES = host-flex host-bison
> +AER_INJECT_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)

This variable was not needed, you can just use TARGET_CONFIGURE_OPTS
directly.

> +
> +define AER_INJECT_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(AER_INJECT_MAKE_OPTS)
> +endef
> +
> +define AER_INJECT_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(AER_INJECT_MAKE_OPTS) \
> +	DESTDIR=$(TARGET_DIR) PREFIX=/usr/bin install

The continuation line should be indented.

> +endef
> +
> +$(eval $(generic-package))
> \ No newline at end of file

There should be a newline at the end of file.

I've fixed up those minor issues and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-03-30 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 13:01 [Buildroot] [PATCH 1/1] aer-inject: new package tiago.brusamarello
2016-03-30 16:26 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330182653.6d1791c0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox