From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tcl: rework logic for databases support
Date: Wed, 30 Mar 2016 21:06:52 +0200 [thread overview]
Message-ID: <20160330210652.4bf25f61@free-electrons.com> (raw)
In-Reply-To: <56FC22FF.5020900@mind.be>
Hello,
On Wed, 30 Mar 2016 21:03:27 +0200, Arnout Vandecappelle wrote:
> > That was my first approach and I didn't look nicer to me, so I changed
> > it :P Anyway, if you prefer that way, I'll do it that way, no problem.
>
> Like you, Vincent, I also prefer TCL_DEPENDENCIES to be repeated.
>
> - You don't need to move your eyes to see which variable is affected.
> - When adding/removing a dependency, you don't have to worry about the backslashes.
>
>
> I do prefer in this case that all assignments, including the first one, have +=
Matter of taste, I guess. But if I follow your thought, then we should
do:
LIBGTK3_CONF_OPTS += --disable-glibtest
LIBGTK3_CONF_OPTS += --enable-explicit-deps=no
LIBGTK3_CONF_OPTS += --enable-gtk2-dependency
LIBGTK3_CONF_OPTS += --disable-introspection
I think this is really verbose, but again a matter of taste.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-30 19:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:21 [Buildroot] [PATCH] tcl: rework logic for databases support Vicente Olivert Riera
2016-03-30 15:35 ` Thomas Petazzoni
2016-03-30 15:39 ` Vicente Olivert Riera
2016-03-30 15:41 ` Thomas Petazzoni
2016-03-30 15:43 ` Vicente Olivert Riera
2016-03-30 19:03 ` Arnout Vandecappelle
2016-03-30 19:06 ` Thomas Petazzoni [this message]
2016-03-30 19:49 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330210652.4bf25f61@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox