From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] norm: fix build failure with old headers
Date: Thu, 31 Mar 2016 18:30:31 +0200 [thread overview]
Message-ID: <20160331183031.503a0e22@free-electrons.com> (raw)
In-Reply-To: <56FD4EE5.9000701@zacarias.com.ar>
Hello,
On Thu, 31 Mar 2016 13:23:01 -0300, Gustavo Zacarias wrote:
> Indeed it's probably not acceptable for old netfilter_queue
> compatibility, though i made it the quick way since it was polluting the
> autobuilders.
Sure. That's also why I applied.
> It's waf, my famous friend, i'll try to cook up a failproof test for it,
> unfortunately netfilter_queue doesn't version the API in a visible way,
> so maybe a pkg-config though i need to consult the author/maintainer
> since it would be a new dependency to build.
I think version-based checks are broken. You should instead have a
check that actually tries to build a small piece of code that tests if
the API is old/new and see if the builds succeeds/fails.
But yeah, waf. Good luck.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-31 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:45 [Buildroot] [PATCH] norm: fix build failure with old headers Gustavo Zacarias
2016-03-31 16:18 ` Thomas Petazzoni
2016-03-31 16:23 ` Gustavo Zacarias
2016-03-31 16:30 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331183031.503a0e22@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox