From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 3/3] dropbear: use libtomath & libtomcrypt
Date: Sat, 2 Apr 2016 17:09:35 +0200 [thread overview]
Message-ID: <20160402170935.7030becf@free-electrons.com> (raw)
In-Reply-To: <1459524973-26730-3-git-send-email-francois.perrad@gadz.org>
Hello,
On Fri, 1 Apr 2016 17:36:13 +0200, Francois Perrad wrote:
> +ifeq ($(BR2_PACKAGE_LIBTOMMATH)$(BR2_PACKAGE_LIBTOMCRYPT),yy)
> +DROPBEAR_DEPENDENCIES += libtommath libtomcrypt
> +DROPBEAR_CONF_OPTS += --disable-bundled-libtom
> +else
> +DROPBEAR_CONF_OPTS += --enable-bundled-libtom
> +endif
Our principle is to avoid bundled libraries when possible. So should we
make Dropnbear always select libtommath/libtomcrypt ?
We could make an exception for Dropbear, as its main point is to be
small and fast to build, and unbundling will necessarily mean a
slightly longer build.
With bundled libraries (i.e original, building dropbear only) :
real 0m19.178s
user 0m35.240s
sys 0m5.308s
With unbundled libraries (i.e with libtommath/libtomcrypt built
separately) :
real 0m23.593s
user 0m50.500s
sys 0m6.000s
Not super significant change. So I think I'm in favor of unbundling.
Other opinions?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-02 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 15:36 [Buildroot] [V2 1/3] libtommath: new package Francois Perrad
2016-04-01 15:36 ` [Buildroot] [V2 2/3] libtomcrypt: " Francois Perrad
2016-04-01 15:54 ` Yegor Yefremov
2016-04-02 14:58 ` Thomas Petazzoni
2016-04-01 15:36 ` [Buildroot] [V2 3/3] dropbear: use libtomath & libtomcrypt Francois Perrad
2016-04-02 15:09 ` Thomas Petazzoni [this message]
2016-04-01 15:55 ` [Buildroot] [V2 1/3] libtommath: new package Yegor Yefremov
2016-04-02 14:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160402170935.7030becf@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox