From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] qt5webkit: restore package
Date: Wed, 13 Apr 2016 22:06:46 +0200 [thread overview]
Message-ID: <20160413220646.102e7cd5@free-electrons.com> (raw)
In-Reply-To: <1460554835-5242-1-git-send-email-gary.bisson@boundarydevices.com>
Hello,
Thanks. Looks mostly good, but I have a few questions.
On Wed, 13 Apr 2016 15:40:35 +0200, Gary Bisson wrote:
> Since we are now using the source from the git repository, we need
> to create an empty .git/ folder to force the headers re-generation.
> https://github.com/meta-qt5/meta-qt5/blob/jethro/recipes-qt/qt5/qt5.inc#L33
>
> Note that GPLv3 license option has been added with this release.
Yes, but I don't see any reference to GPLv3 in your license information
below.
> +ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
> +QT5WEBKIT_LICENSE = LGPLv2+, BSD-3c, BSD-2c
> +# Source files contain references to LGPL_EXCEPTION.txt but it is not included
> +# in the archive.
> +QT5WEBKIT_LICENSE_FILES += LICENSE.LGPLv21
> +else
> +QT5WEBKIT_LICENSE = LGPLv2+ (WebCore), Commercial license
> +QT5WEBKIT_REDISTRIBUTE = NO
> +endif
No reference to GPLv3 whatsoever.
Also, LGPLv2+ is not correct I believe, it should be LGPLv2.1+, as the
name of the license file suggests.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-13 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 13:40 [Buildroot] [PATCH v4] qt5webkit: restore package Gary Bisson
2016-04-13 20:06 ` Thomas Petazzoni [this message]
2016-04-13 20:20 ` Arnout Vandecappelle
2016-04-14 8:03 ` Gary Bisson
2016-04-18 20:53 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413220646.102e7cd5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox