From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/1] PyMySQL: new package
Date: Wed, 13 Apr 2016 22:20:02 +0200 [thread overview]
Message-ID: <20160413222002.3dfe7068@free-electrons.com> (raw)
In-Reply-To: <1460497151-29117-1-git-send-email-stevecalfee@gmail.com>
Hello,
On Tue, 12 Apr 2016 14:39:11 -0700, Steve Calfee wrote:
> add python to MySQL connection software, written in pure python
>
> Signed-off-by: Steve Calfee <stevecalfee@gmail.com>
The title of the commit should have used the package name:
python-pymysql: new package
> diff --git a/package/python-pymysql/Config.in b/package/python-pymysql/Config.in
> new file mode 100644
> index 0000000..d0db376
> --- /dev/null
> +++ b/package/python-pymysql/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_PYMYSQL
> + bool "python-pymysql"
> + help
> + PyMySQL is a pure-Python MySQL client library.
There was a trailing whitespace on this line.
Also, your patch did not apply due to a conflict in package/Config.in,
caused by packages that were added quite some time ago in Buildroot.
This seems to indicate that you are not working on top of the latest
master. Please submit patches that are based and tested on top of the
latest master.
I've applied after fixing the minor issues mentioned above. Thanks a
lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-04-13 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 21:39 [Buildroot] [PATCH v6 1/1] PyMySQL: new package Steve Calfee
2016-04-12 21:48 ` Arnout Vandecappelle
2016-04-13 20:20 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413222002.3dfe7068@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox