From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gutenprint: fix host build
Date: Fri, 15 Apr 2016 21:28:28 +0200 [thread overview]
Message-ID: <20160415212828.1895181f@free-electrons.com> (raw)
In-Reply-To: <20160415180212.GA11682@waldemar-brodkorb.de>
Hello,
On Fri, 15 Apr 2016 20:02:12 +0200, Waldemar Brodkorb wrote:
> ++AC_ARG_WITH([libusb], AS_HELP_STRING([--with-libusb], [Build with USB backend support]))
I think you should add the last AC_ARG_WITH() argument that makes sure
that the default value remains "yes". Something like:
AC_ARG_WITH([libusb],
AS_HELP_STRING([--with-libusb], [Build with USB backend support]),
[],
[with_libusb=yes])
(or something like that)
Otherwise, if --with-libusb is not passed explicitly, USB support will
not be enabled, which is a change in behavior compared to the current
situation.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-04-15 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 18:02 [Buildroot] [PATCH v2] gutenprint: fix host build Waldemar Brodkorb
2016-04-15 19:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415212828.1895181f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox