From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sun, 17 Apr 2016 22:50:45 +0200
Subject: [Buildroot] [PATCH v2] imx-uuc: add new package
In-Reply-To: <1460544052-31608-1-git-send-email-gary.bisson@boundarydevices.com>
References: <1460544052-31608-1-git-send-email-gary.bisson@boundarydevices.com>
Message-ID: <20160417225045.26b26138@free-electrons.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello,

The commit title should have been:

	imx-uuc: new package

(yes that's nitpicking)

On Wed, 13 Apr 2016 12:40:52 +0200, Gary Bisson wrote:
> diff --git a/package/freescale-imx/imx-uuc/Config.in b/package/freescale-imx/imx-uuc/Config.in
> new file mode 100644
> index 0000000..75e4c87
> --- /dev/null
> +++ b/package/freescale-imx/imx-uuc/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_IMX_UUC
> +	bool "imx-uuc"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_arm # Only relevant for i.MX
> +	select BR2_PACKAGE_HOST_DOSFSTOOLS
> +	help
> +	  This package provides the Universal Adapter user-space utility
> +	  that is used to receive commands from the Manufacturing Tool
> +	  using the Freescale UTP Protocol.
> +
> +	  It requires a Freescale/NXP kernel whose configuration contains
> +	  the CONFIG_FSL_UTP option.
> +
> +	  This package is provided by Freescale/NXP as-is and doesn't have
> +	  an upstream.

Some of those lines were slightly too long, so I rewrapped.

> +
> +comment "imx-uuc needs a toolchain w/ threads"
> +	depends on BR2_ARM

BR2_arm, not BR2_ARM.

> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/freescale-imx/imx-uuc/S80imx-uuc b/package/freescale-imx/imx-uuc/S80imx-uuc
> new file mode 100644
> index 0000000..8d6d8c1
> --- /dev/null
> +++ b/package/freescale-imx/imx-uuc/S80imx-uuc
> @@ -0,0 +1,28 @@
> +#!/bin/sh
> +
> +NAME=uuc
> +DAEMON=/usr/bin/$NAME
> +
> +case "$1" in
> +  start)
> +    printf "Starting $NAME: "
> +    start-stop-daemon -S -q -b -p /var/run/${NAME}.pid -x $DAEMON
> +    echo "OK"

I've added missing error checking here.

> +    ;;
> +  stop)
> +    printf "Stopping $NAME: "
> +    start-stop-daemon -K -q -p /var/run/${NAME}.pid
> +    echo "OK"

And here. I've also re-indented the init script to match the
indentation used in S50dropbear (which I believe is more or less our
reference).

> diff --git a/package/freescale-imx/imx-uuc/imx-uuc.hash b/package/freescale-imx/imx-uuc/imx-uuc.hash
> new file mode 100644
> index 0000000..aab9ea8
> --- /dev/null
> +++ b/package/freescale-imx/imx-uuc/imx-uuc.hash
> @@ -0,0 +1 @@
> +sha256 95d7f7b075f58fedc07602fbc0e5bf5212d28deea3d09cdbcbd80992dcd18482  imx-uuc-0.5.1.tar.gz

Missing source for the hash, so I've assumed it had been locally
calculated, and added the usual comment.

Applied with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com