Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] flatcc: new package
Date: Mon, 18 Apr 2016 09:07:41 +0200	[thread overview]
Message-ID: <20160418090741.75aa988a@free-electrons.com> (raw)
In-Reply-To: <57140E40.9040700@mind.be>

Hello,

On Mon, 18 Apr 2016 00:29:20 +0200, Arnout Vandecappelle wrote:

> > +define HOST_FLATCC_INSTALL_CMDS
> > +	$(INSTALL) -D -m 0755 $(@D)/bin/flatcc $(HOST_DIR)/usr/bin/flatcc
> 
>   I was going to say: this shouldn't be needed - but in fact it is, it looks 
> like they have a weird CMakeLists.txt that doesn't even have an 'install' 
> target... Se yes, this is needed.

Then this definitely calls for a comment that explains why this is
needed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-04-18  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-16  1:23 [Buildroot] [PATCH 1/1] flatcc: new package Steve deRosier
2016-04-17 22:29 ` Arnout Vandecappelle
2016-04-18  7:07   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418090741.75aa988a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox