Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] imx-uuc: add new package
Date: Mon, 18 Apr 2016 11:52:52 +0200	[thread overview]
Message-ID: <20160418115252.3c0b466d@free-electrons.com> (raw)
In-Reply-To: <CAAMH-yusq577jhLtDEHaJbYRpBD4KsLwGDzqDU1tD_k2fkie4Q@mail.gmail.com>

Hello,

On Mon, 18 Apr 2016 11:38:00 +0200, Gary Bisson wrote:

> >         imx-uuc: new package
> >
> > (yes that's nitpicking)
> 
> No that's good to know, next time I'll make sure to name it like this.

No problem, it's easy to fix :)

> > Some of those lines were slightly too long, so I rewrapped.
> 
> What number of characters would you like to see? I always go by the
> 80-character line rule.

72 characters is our rule, including the tab+2 spaces indentation.

> > And here. I've also re-indented the init script to match the
> > indentation used in S50dropbear (which I believe is more or less our
> > reference).
> 
> Good to know too, I actually randomly copied one init script already
> present (S53neard).

Our init scripts are far from being very consistent, so no problem with
this. We should probably write down a few rules, and do a bit of
cleanup work so that they look more similar.

> > Applied with those changes, thanks!
> 
> No problem, I just want to add one thing that I discovered last week,
> there's a Linux equivalent of the MFGTools developed by Ixonos:
> https://github.com/ixonos/utp_com
> 
> It allows to do the same thing, send flashing scripts, executing
> commands, flashing partitions etc... I might add it to the host
> packages some day but it unfortunately depends on libsgutils2-dev for
> the scsi headers in order to build. Not sure what the best approach
> is.

Just create a host package for libsgutils, and make host-utp-com depend
on it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-04-18  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 10:40 [Buildroot] [PATCH v2] imx-uuc: add new package Gary Bisson
2016-04-17 20:50 ` Thomas Petazzoni
2016-04-18  9:38   ` Gary Bisson
2016-04-18  9:52     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418115252.3c0b466d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox