From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/3] core/pkg-kconfig: Do not use $(call ...) without parameters
Date: Mon, 18 Apr 2016 22:33:10 +0200 [thread overview]
Message-ID: <20160418203310.GD3495@free.fr> (raw)
In-Reply-To: <1460971383-10595-3-git-send-email-romain.izard.pro@gmail.com>
Romain, All,
On 2016-04-18 11:23 +0200, Romain Izard spake thusly:
> When there are no parameters, simply use $(var) instead of $(call var)
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Changelog:
> v3: new
> v4: no change
>
> package/pkg-kconfig.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk
> index cb177bb..4033915 100644
> --- a/package/pkg-kconfig.mk
> +++ b/package/pkg-kconfig.mk
> @@ -87,7 +87,7 @@ define $(2)_FIXUP_DOT_CONFIG
> endef
>
> $$($(2)_DIR)/.stamp_kconfig_fixup_done: $$($(2)_DIR)/.config
> - $$(call $(2)_FIXUP_DOT_CONFIG)
> + $$($(2)_FIXUP_DOT_CONFIG)
>
> # Before running configure, the configuration file should be present and fixed
> $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done
> @@ -139,7 +139,7 @@ $$($(2)_DIR)/.kconfig_editor_%: $$($(2)_DIR)/.stamp_kconfig_fixup_done
> $$($(2)_KCONFIG_OPTS) $$(*)
> rm -f $$($(2)_DIR)/.stamp_{kconfig_fixup_done,configured,built}
> rm -f $$($(2)_DIR)/.stamp_{target,staging,images}_installed
> - $$(call $(2)_FIXUP_DOT_CONFIG)
> + $$($(2)_FIXUP_DOT_CONFIG)
>
> # Saving back the configuration
> #
> --
> 2.5.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-04-18 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 9:23 [Buildroot] [PATCH v4 0/3] core/pkg-kconfig: Fix .config generation Romain Izard
2016-04-18 9:23 ` [Buildroot] [PATCH v4 1/3] core/pkg-kconfig: Factorize make commands Romain Izard
2016-04-18 20:32 ` Yann E. MORIN
2016-04-18 21:17 ` Thomas Petazzoni
2016-04-18 9:23 ` [Buildroot] [PATCH v4 2/3] core/pkg-kconfig: Do not use $(call ...) without parameters Romain Izard
2016-04-18 20:33 ` Yann E. MORIN [this message]
2016-04-18 21:17 ` Thomas Petazzoni
2016-04-18 9:23 ` [Buildroot] [PATCH v4 3/3] core/pkg-kconfig: Use oldnoconfig when possible Romain Izard
2016-04-18 21:08 ` Yann E. MORIN
2016-04-18 21:16 ` Yann E. MORIN
2016-04-19 9:11 ` Romain Izard
2016-04-19 17:40 ` Yann E. MORIN
2016-04-19 17:58 ` Yann E. MORIN
2016-04-20 7:14 ` Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418203310.GD3495@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox