From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 2/4] Add package tegrarcm
Date: Tue, 19 Apr 2016 22:24:43 +0200 [thread overview]
Message-ID: <20160419222443.72658e5d@free-electrons.com> (raw)
In-Reply-To: <1458227038-16383-3-git-send-email-julian@jusst.de>
Hello,
The commit title should have been:
tegrarcm: new package
On Thu, 17 Mar 2016 16:03:56 +0100, Julian Scheel wrote:
> diff --git a/package/tegrarcm/0001-Make-cryptopp-include-crosscompile-compatible.patch b/package/tegrarcm/0001-Make-cryptopp-include-crosscompile-compatible.patch
> new file mode 100644
> index 0000000..ed0d1fc
> --- /dev/null
> +++ b/package/tegrarcm/0001-Make-cryptopp-include-crosscompile-compatible.patch
> @@ -0,0 +1,27 @@
> +From 0e60af53fa76aa2f274ade98da7ba543147e82c7 Mon Sep 17 00:00:00 2001
> +From: Julian Scheel <julian@jusst.de>
> +Date: Thu, 17 Mar 2016 12:37:04 +0100
> +Subject: [PATCH] Make cryptopp include crosscompile compatible
> +
> +Allows user to set a SYSROOT variable for building against a specific root
> +filesystem.
> +
> +Signed-off-by: Julian Scheel <julian@jusst.de>
> +---
> + src/Makefile.am | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/Makefile.am b/src/Makefile.am
> +index 3dad0e6..7678dd4 100644
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -1,5 +1,5 @@
> + AM_CFLAGS = -Wall -std=c99
> +-AM_CPPFLAGS = -isystem /usr/include/$(CRYPTOLIB) $(LIBUSB_CFLAGS)
> ++AM_CPPFLAGS = -isystem $(SYSROOT)/usr/include/$(CRYPTOLIB) $(LIBUSB_CFLAGS)
This is not really the recommended autoconf/automake solution. I've
done a larger patch, but that I believe is more correct, as it relies
on the normal compiler include path logic, and simply makes the source
code include <cryptopp/foobar.h>, where of course cryptopp can also be
crypto++ depending on the library being used.
I've also submitted my patch upstream:
https://github.com/NVIDIA/tegrarcm/pull/2
> diff --git a/package/tegrarcm/tegrarcm.mk b/package/tegrarcm/tegrarcm.mk
> new file mode 100644
> index 0000000..5dbc483
> --- /dev/null
> +++ b/package/tegrarcm/tegrarcm.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# tegrarcm
> +#
> +################################################################################
> +
> +TEGRARCM_VERSION = v1.7
> +TEGRARCM_SITE = $(call github,NVIDIA,tegrarcm,$(TEGRARCM_VERSION))
> +TEGRARCM_LICENSE = BSD-3c / NVIDIA Software License (src/miniloader)
> +TEGRARCM_LICENSE_FILE = LICENSE
> +TEGRARCM_AUTORECONF = YES
> +HOST_TEGRARCM_DEPENDENCIES = host-libusb host-pkgconf host-cryptopp
> +HOST_TEGRARCM_MAKE_OPTS = SYSROOT=$(HOST_DIR)
Due to the patch being changed, I've removed this last line, and
applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-19 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 15:03 [Buildroot] [PATCHv2 0/4] Add flashing tools for tegra processors Julian Scheel
2016-03-17 15:03 ` [Buildroot] [PATCHv2 1/4] Add package cryptopp Julian Scheel
2016-04-19 20:23 ` Thomas Petazzoni
2016-04-21 20:40 ` Thomas Petazzoni
2016-04-22 7:29 ` Julian Scheel
2016-03-17 15:03 ` [Buildroot] [PATCHv2 2/4] Add package tegrarcm Julian Scheel
2016-04-19 20:24 ` Thomas Petazzoni [this message]
2016-03-17 15:03 ` [Buildroot] [PATCHv2 3/4] Add package cbootimage Julian Scheel
2016-04-19 20:34 ` Thomas Petazzoni
2016-03-17 15:03 ` [Buildroot] [PATCHv2 4/4] Add package cbootimage-configs Julian Scheel
2016-04-19 21:08 ` Thomas Petazzoni
2016-04-19 22:36 ` Arnout Vandecappelle
2016-04-20 6:18 ` Julian Scheel
2016-04-20 7:11 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419222443.72658e5d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox