From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/4] libpjsip: add gnutls support and fix various things
Date: Fri, 22 Apr 2016 23:21:55 +0200 [thread overview]
Message-ID: <20160422232155.6ac9c7e2@free-electrons.com> (raw)
In-Reply-To: <1461358628-9352-2-git-send-email-patrick.keroulas@savoirfairelinux.com>
Hello,
Thanks for your contributions!
On Fri, 22 Apr 2016 16:57:05 -0400, Patrick Keroulas wrote:
> Endianness for ARM.
> Add missing errno.
> Add multiple listeners.
> Fix ICE config and session.
As the commit title suggests, this patch does too many things in one
patch. Each of the things that you list here should be done by a
separate patch.
> package/libpjsip/0003-Add-gnutls-support.patch | 3373 ++++++++++++++++++++
Please don't include the generated configure script changes. Just patch
configure.ac, and mark the package with <pkg>_AUTORECONF = YES.
However, Buildroot has the policy of not carrying feature patches,
which this one clearly is. Some please get this patch integrated
upstream first, and then we can benefit from this feature in Buildroot.
Having large feature patches like this one in Buildroot would prevent
us from easily updating libpjsip in the future, which is not a
situation we like.
Patches fixing bugs/issues are OK, but not feature patches.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-22 21:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 20:57 [Buildroot] [PATCH v1 0/4] Patrick Keroulas
2016-04-22 20:57 ` [Buildroot] [PATCH v1 1/4] libpjsip: add gnutls support and fix various things Patrick Keroulas
2016-04-22 21:21 ` Thomas Petazzoni [this message]
2016-05-03 21:08 ` Patrick Keroulas
2016-05-03 21:43 ` Arnout Vandecappelle
2016-05-04 15:22 ` Patrick Keroulas
2016-05-04 19:23 ` Arnout Vandecappelle
2016-04-22 20:57 ` [Buildroot] [PATCH v1 2/4] msgpack: bump to version 1.4.0 Patrick Keroulas
2016-04-22 21:23 ` Thomas Petazzoni
2016-05-02 20:57 ` Patrick Keroulas
2016-04-22 21:52 ` Thomas Petazzoni
2016-04-22 20:57 ` [Buildroot] [PATCH v1 3/4] openDHT: new package Patrick Keroulas
2016-04-22 21:30 ` Thomas Petazzoni
2016-04-22 20:57 ` [Buildroot] [PATCH v1 4/4] ring-daemon: " Patrick Keroulas
2016-04-22 22:19 ` Thomas Petazzoni
2016-04-25 14:29 ` Jérôme Oufella
2016-04-25 18:18 ` Patrick Keroulas
2016-04-25 19:24 ` Thomas Petazzoni
2016-04-25 21:20 ` Patrick Keroulas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422232155.6ac9c7e2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox