Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mono: Disabling for sparc32
Date: Sun, 24 Apr 2016 17:23:04 +0200	[thread overview]
Message-ID: <20160424172304.11d30f33@free-electrons.com> (raw)
In-Reply-To: <1461507387-2966-1-git-send-email-angelo.compagnucci@gmail.com>

Hello,

On Sun, 24 Apr 2016 16:16:27 +0200, Angelo Compagnucci wrote:
> Mono cannot be compiled for sparc32 (v8/leon) so disabling it.
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
>  package/mono/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

>  	default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \
> -		      BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64)
> +		      BR2_mipsel || BR2_powerpc || BR2_sparc64 || BR2_x86_64)

And you're enabling for sparc64 at the same time, which is not
explained in your commit log.

Also, Waldemar sent a patch one hour before that disables it for SPARC,
without enabling it for SPARC64, because it also doesn't build for
SPARC64.

So I've marked your patch as Rejected in our patch tracking system.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-24 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 14:16 [Buildroot] [PATCH] package/mono: Disabling for sparc32 Angelo Compagnucci
2016-04-24 15:23 ` Thomas Petazzoni [this message]
2016-04-24 17:42   ` Angelo Compagnucci
2016-04-24 17:54     ` Waldemar Brodkorb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160424172304.11d30f33@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox