Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 4/5] barebox: support 2nd config build
Date: Sun, 24 Apr 2016 17:58:03 +0200	[thread overview]
Message-ID: <20160424175803.72e59938@free-electrons.com> (raw)
In-Reply-To: <f8d6dec31737cde2abaf82ee4f64ea215e48e452.1461489060.git.pieter@boesman.nl>

Hello,

On Sun, 24 Apr 2016 11:18:46 +0200, Pieter Smith wrote:

>  boot/barebox/Config.in                |  2 +
>  boot/barebox/barebox-2/Config.in      | 72 +++++++++++++++++++++++++++++++++++
>  boot/barebox/barebox-2/barebox-2.hash |  1 +
>  boot/barebox/barebox-2/barebox-2.mk   |  9 +++++
>  boot/barebox/barebox.mk               |  3 ++

Regarding this one, I am not sure, there are two things that bother me
a bit:

 - The name "barebox-2", which I find a bit weird. What about
   "barebox-aux" or something like that, as opposed to "barebox-main" ?

 - The organization of the folders. Having the barebox "infra" + the
   main barebox package both defined in boot/barebox/barebox.mk seems
   weird. Ideally, I would have preferred something like:

   boot/barebox/barebox.mk <-- common infrastructure
   boot/barebox/barebox-main/ <-- the main Barebox
   boot/barebox/barebox-aux/  <-- the auxiliary Barebox

   Of course, some tricks will be needed to make the barebox-main/
   package behave properly when its options will still be named
   BR2_TARGET_BAREBOX_<foo> and not BR2_TARGET_BAREBOX_MAIN_<foo>.
   Alternatively, if that really doesn't work, what about:

   boot/barebox/barebox.mk <-- common infrastructure
   boot/barebox/barebox/ <-- the main Barebox
   boot/barebox/barebox-aux/  <-- the auxiliary Barebox

I've applied the first three patches of the series to ease your work,
but I'd like to see if we can get something a bit better for this
patch. I know Arnout has done a lot of review, so don't hesitate to let
me know if all this has already been discussed and why the current
organization has been chosen compared to something more similar to my
proposal.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-04-24 15:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24  9:18 [Buildroot] [PATCH v5 0/5] Support building a 2nd Barebox config Pieter Smith
2016-04-24  9:18 ` [Buildroot] [PATCH v5 1/5] barebox: support multi-image-build image selection Pieter Smith
2016-04-24 15:43   ` Thomas Petazzoni
2016-04-24 21:20     ` Pieter Smith
2016-04-24  9:18 ` [Buildroot] [PATCH v5 2/5] barebox: introduce barebox-package function Pieter Smith
2016-04-24 15:54   ` Thomas Petazzoni
2016-04-24 21:21     ` Pieter Smith
2016-04-24  9:18 ` [Buildroot] [PATCH v5 3/5] barebox: extract package name argument Pieter Smith
2016-04-24 15:54   ` Thomas Petazzoni
2016-04-24 21:21     ` Pieter Smith
2016-04-24  9:18 ` [Buildroot] [PATCH v5 4/5] barebox: support 2nd config build Pieter Smith
2016-04-24 15:58   ` Thomas Petazzoni [this message]
2016-04-24 16:52     ` Pieter Smith
2016-04-24  9:18 ` [Buildroot] [PATCH v5 5/5] beaglebone: adds barebox bootloader defconfig Pieter Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160424175803.72e59938@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox