[Buildroot] [PATCH 1/2] uboot and arm trusted firmware build added to juno board

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Thu, 28 Apr 2016 18:21:50 +0100, Joao Pinto wrote:

> # Automatically find the U-Boot binary
> ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME), )

use qstrip, otherwise this will never be true. Also, remove the space
after the comma.

> ATFIRMWARE_PAYLOAD_PATH = $(BINARIES_DIR)/"u-boot.bin"

Remove the quotes.

> else
> ATFIRMWARE_PAYLOAD_PATH = $(BINARIES_DIR)/$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME)

Use qstrip here as well.

Are you sure it's either u-boot.bin or a custom name? There are plenty
of other possible image names in uboot.mk (but quite certainly not all
of them apply to ARM64).

> In terms of the SCP_FW, I think for now is more reliable to make the final stage
> manually if using a Juno board. From my experience stuff in Linaro repositories
> change frequently and so we have a good probability of breaking the binary download.
> I suggest to put a note in the readme.txt saying what should be done, since
> everyone using a Juno will have access to the SCP FW in the board.
> 
> What do you think?

Sounds OK. Having everything built automatically is better, but as a
first step, it's definitely OK as long as there are explanations in
readme.txt.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com