Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fdk-aac: fix build with GCC 6
Date: Sun, 1 May 2016 22:35:20 +0200	[thread overview]
Message-ID: <20160501223520.73aba2d7@free-electrons.com> (raw)
In-Reply-To: <1462094288-8110-1-git-send-email-joerg.krause@embedded.rocks>

Hello,

On Sun,  1 May 2016 11:18:08 +0200, J?rg Krause wrote:
> GCC 6 defaults to -std=gnu++14 instead of -std=gnu++98. The C++11 standard does
> not allow "narrowing conversions" which is why building fdk-aac with GCC 6
> fails:
> 
> libAACenc/src/aacEnc_rom.cpp:661:1: error: narrowing conversion of '2180108801u' from 'unsigned int' to 'FIXP_DBL {aka long int}' inside { } [-Wnarrowing]
> 
> Use '-std=gnu++98' as suggested by "Porting to GCC 6" [1].
> 
> [1] https://gcc.gnu.org/gcc-6/porting_to.html
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  package/fdk-aac/fdk-aac.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, but please report the bug upstream so that they fix
in their source code or build system. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-05-01 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-01  9:18 [Buildroot] [PATCH] fdk-aac: fix build with GCC 6 Jörg Krause
2016-05-01 20:35 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160501223520.73aba2d7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox