From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] swupdate: bump to version 2016.04
Date: Mon, 2 May 2016 11:37:26 +0200 [thread overview]
Message-ID: <20160502113726.66942fc8@free-electrons.com> (raw)
In-Reply-To: <1462178921.5359.5.camel@embedded.rocks>
Hello,
On Mon, 02 May 2016 10:48:41 +0200, J?rg Krause wrote:
> > > ?* Remove comment about bundled lsqlite3, it has been removed.
> > > ?* Remove upstream patches:
> > > ????- "Kbuild: Fix link error for CONFIG_UBOUT and missing libz"
> > > [1]
> > > ????- "Kbuild: Link with GCC instead of LD" [2]
> > > ?* Add patch from upstream:
> > > ????- "Fix build without MTD support" [3]
> > > ?* Add optional dependency for libarchive
> > > ?* Add optional dependency for uboot-tools
> > > ?* Lua support is not restricted to Lua 5.2
> > >
> > > [1] https://github.com/sbabic/swupdate/commit/5a5ef5909f5da5b2070d5
> > > 8ffaee924bb8e6a51e1
> > > [2] https://github.com/sbabic/swupdate/commit/f26577423eb65728fcd10
> > > f78f9978dd07d51dcb9
> > > [3] https://github.com/sbabic/swupdate/commit/69c0e66994f01ce1bf229
> > > 9fbce86aee7a1baa37b
> > >
> > > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> >
> > > ? ??* Select BR2_PACKAGE_ZLIB if you want to deal with gzip
> > > compressed
> > > ? ????archives.
> > > + ??* Select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV and
> > > BR2_PACKAGE_ZLIB to
> > > + ????add support for setting the U-Boot environment.
> >
> > But in the .mk file itself you're setting HAVE_LIBUBOOTENV=y as soon
> > as
> > BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV=y, even if BR2_PACKAGE_ZLIB is
> > disabled. Isn't that somewhat inconsistent?
>
> No. It's not about enable U-Boot support, but setting the available
> libraries through the environment. With this, swupdates KConfig checks
> for?HAVE_LIBUBOOTENV and?HAVE_ZLIB to enable U-Boot support.
Hum, ok, makes sense. Thanks for the explanation. Can you respin a
patch series with the other comments addressed?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-05-02 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 7:56 [Buildroot] [PATCH 0/3] package/swupdate: bump to version 2016.04 Jörg Krause
2016-04-29 7:56 ` [Buildroot] [PATCH 1/3] mtd: install header files to staging directory Jörg Krause
2016-05-01 20:36 ` Thomas Petazzoni
2016-04-29 7:56 ` [Buildroot] [PATCH 2/3] uboot-tools: install libubootenv to staging Jörg Krause
2016-05-01 20:45 ` Thomas Petazzoni
2016-04-29 7:57 ` [Buildroot] [PATCH 3/3] swupdate: bump to version 2016.04 Jörg Krause
2016-05-01 20:48 ` Thomas Petazzoni
2016-05-02 8:48 ` Jörg Krause
2016-05-02 9:37 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502113726.66942fc8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox