Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/13 v6] core/legal-info: install source archives in their own sub-dir
Date: Fri, 6 May 2016 00:55:25 +0200	[thread overview]
Message-ID: <20160505225525.GG4367@free.fr> (raw)
In-Reply-To: <2db32ff5-7ff9-e343-d31b-cb06404a1017@mind.be>

Arnout, All,

On 2016-05-04 01:14 +0200, Arnout Vandecappelle spake thusly:
> On 04/29/16 00:27, Yann E. MORIN wrote:
> >Currently, we put all source archives side-by-side in the same
> >directory.
> >
> >Since we're about to also save individual patches that were applied
> >on those sources, we don't want to make that directory a complete
> >mess of unassorted files.
> >
> >So, we install each source archive in its own sub-directory, where
> >we'll later store the patches too. Store that location in a variable,
> >so it can be re-used later on (to install patches in a future commit).
> >
> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >Cc: Luca Ceresoli <luca@lucaceresoli.net>
> >Acked-by: Luca Ceresoli <luca@lucaceresoli.net>
> >Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
> >Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >
> >---
> >Chages v5 -> v6:
> >  - variable with raw name was renamed  (Thomas)
> >
> >Changes v1 -> v2:
> >  - perl no longer has a post-legal-info hook  (Thomas, Luca)
> >---
> > package/pkg-generic.mk | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> >diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> >index 7aca958..a362b73 100644
> >--- a/package/pkg-generic.mk
> >+++ b/package/pkg-generic.mk
> >@@ -496,6 +496,8 @@ endif
> >
> > $(2)_REDISTRIBUTE		?= YES
> >
> >+$(2)_REDIST_SOURCES_DIR = $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))/$$($(2)_RAW_BASE_NAME)
> >+
> > # When a target package is a toolchain dependency set this variable to
> > # 'NO' so the 'toolchain' dependency is not added to prevent a circular
> > # dependency
> >@@ -823,8 +825,8 @@ else
> >
> > ifeq ($$($(2)_REDISTRIBUTE),YES)
> > # Save the source tarball
> >-	$$(Q)$$(HARDLINK_OR_COPY) $$(DL_DIR)/$$($(2)_ACTUAL_SOURCE_TARBALL),\
> >-				  $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))
> >+	$$(Q)$$(HARDLINK_OR_COPY) $$(DL_DIR)/$$($(2)_ACTUAL_SOURCE_TARBALL) \
> 
>  Did I really give my Rev-by without noticing that comma disappearing? :-)

No, you did not; it's a tag from a previous review.

I dropped some tags from some patches, but forgot to do so here. Sorry...

Regards,
Yann E. MORIN.

>  Regards,
>  Arnout
> 
> >+				  $$($(2)_REDIST_SOURCES_DIR)
> > endif # redistribute
> >
> > endif # other packages
> >
> 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-05-05 22:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 22:27 [Buildroot] [PATCH 00/13 v6] legal-info improvements and completeness (branch yem/legal-3) Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 01/13 v6] support/scripts: add helper to hardlink-or-copy Yann E. MORIN
2016-05-03 22:53   ` Arnout Vandecappelle
2016-05-05 22:38     ` Yann E. MORIN
2016-05-07 18:44       ` Arnout Vandecappelle
2016-05-08  7:25         ` Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 02/13 v6] core/legal-info: use the helper to install source archives Yann E. MORIN
2016-05-03 22:57   ` Arnout Vandecappelle
2016-05-05 22:44     ` Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 03/13 v6] core/pkg-generic: reorder variables definitions for legal-info Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 04/13 v6] core/legal-info: ensure legal-info works in off-line mode Yann E. MORIN
2016-05-03 23:13   ` Arnout Vandecappelle
2016-04-28 22:27 ` [Buildroot] [PATCH 05/13 v6] core/pkg-generic: add variable to store the package rawname-version Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 06/13 v6] core/legal-info: install source archives in their own sub-dir Yann E. MORIN
2016-05-03 23:14   ` Arnout Vandecappelle
2016-05-05 22:55     ` Yann E. MORIN [this message]
2016-04-28 22:27 ` [Buildroot] [PATCH 07/13 v6] core/legal-info: add package version to license directory Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 08/13 v6] core/apply-patches: store full path of applied patches Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 09/13 v6] core/legal-info: also save patches Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 10/13 v6] support/apply-patches: bail-out on duplicate patch basenames Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 11/13 v6] core/legal-info: also save extra downloads Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 12/13 v6] core/legal-info: generate a hash of all saved files Yann E. MORIN
2016-04-28 22:27 ` [Buildroot] [PATCH 13/13 v6] legal-info: explicitly state how patches are licensed Yann E. MORIN
2016-05-03 22:34   ` Arnout Vandecappelle
2016-05-03 22:33 ` [Buildroot] [PATCH 00/13 v6] legal-info improvements and completeness (branch yem/legal-3) Arnout Vandecappelle
2016-05-05 22:01   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160505225525.GG4367@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox