[Buildroot] [PATCH] ipsec-tools: add patches to fix musl build

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Sun,  8 May 2016 13:32:06 +0200, J?rg Krause wrote:

> 1) Fix missing definition of __P() macro:
> 
> __P was used for compatibility with some old K&R C compilers, when there were
> no prototypes (which were introduced to C with C89).
> 
> This macro definition is not available when building with the musl C library,
> so the local compatibility header "gnuc.h" already present in one of the
> subdirs is made available for all subdirs and the necessary include is added
> to the needed header and source files.

Isn't it simpler to just drop __P from where it is used? Do they still
need to support those old K&R C compilers that predate C89 ? That seem
very unlikely, no?

> 4) Check for strtouq
> 
> strtouq() is a BSD function and not available on musl. Add a autoconf check
> for its present and if not available, replace it with its equivalent strtoull
> or strtoul (if strtoull is not available).

Are you sure replacing strtouq by strtoul is safe? strtouq() is
converting to a 64 bits integer, while strtoul() converts to an
unsigned long, which is only 32 bits on 32 bits architectures. So
replacing strtouq() with strtoul() on 32 bits architectures is only
safe if you're sure that the value being passed fits on 32 bits.


> +# We are patch configure.ac, so we need to run autoreconfigure the package.

are patch -> are patching

> +# Although this package uses autoconf, it does not work with the autoreconf
> +# tool, so we # need to call their bootstrap script which does the

# sign in a middle of a line, probably a rewrap that went wrong.

> +# reconfiguration.
> +define IPSEC_TOOLS_RUN_BOOTSTRAP
> +	cd $(@D) && PATH=$(BR_PATH) ./bootstrap
> +endef
> +IPSEC_TOOLS_PRE_CONFIGURE_HOOKS += IPSEC_TOOLS_RUN_BOOTSTRAP

You need to add host-autoconf (and possibly host-automake/host-libtool)
in the dependencies for this to work.

Or alternatively, fix the autoreconfiguration problems so that it
autoreconfigures properly :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com