From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/9] package/go: Add BR2_TOOLCHAIN_HAS_THREADS
Date: Thu, 12 May 2016 16:12:52 +0200 [thread overview]
Message-ID: <20160512161252.7471bf1e@free-electrons.com> (raw)
In-Reply-To: <62cf6f9a00fe67cf999e45f7cbf4bf2e295a0fd5.1463010771.git.geoff@infradead.org>
Hello,
On Thu, 12 May 2016 00:08:46 +0000, Geoff Levand wrote:
> CGO needs thread support. Fixes build errors like these:
>
> warning requested reentrant code, but thread support was disabled
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/go/Config.in.host | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/go/Config.in.host b/package/go/Config.in.host
> index 094e402..e988483 100644
> --- a/package/go/Config.in.host
> +++ b/package/go/Config.in.host
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
> bool
> default y
> + depends on BR2_TOOLCHAIN_HAS_THREADS
This is not an architecture dependency, it's a toolchain dependency. We
normally show a comment about such a dependency so that users know they
need to enable thread support in their toolchain.
When you say "CGO needs thread support", is CGO the go runtime on the
target? Does this means that any Go program needs threads?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-12 14:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 0:08 [Buildroot] [PATCH 0/9] Fixes for go language support Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 1/9] package/go-bootstrap: Add toolchain dependency Geoff Levand
2016-05-12 14:11 ` Thomas Petazzoni
2016-05-12 0:08 ` [Buildroot] [PATCH 4/9] package/go: Add BR2_TOOLCHAIN_HAS_THREADS Geoff Levand
2016-05-12 13:30 ` Thomas Petazzoni
2016-05-12 14:12 ` Thomas Petazzoni [this message]
2016-05-12 18:32 ` Geoff Levand
2016-05-13 13:35 ` Thomas Petazzoni
2016-05-13 16:21 ` Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 3/9] package/go-bootstrap: Set CC to host CC Geoff Levand
2016-05-12 13:28 ` Thomas Petazzoni
2016-05-12 16:53 ` Geoff Levand
2016-05-13 13:30 ` Thomas Petazzoni
2016-05-12 0:08 ` [Buildroot] [PATCH 2/9] package/go-bootstrap: Set CGO_ENABLED=0 Geoff Levand
2016-05-12 14:11 ` Thomas Petazzoni
2016-05-13 11:56 ` Peter Korsgaard
2016-05-13 16:05 ` Geoff Levand
2016-05-13 17:12 ` Peter Korsgaard
2016-05-13 18:40 ` Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 5/9] package/go: Fix powerpc64 config typo Geoff Levand
2016-05-12 14:26 ` Thomas Petazzoni
2016-05-12 0:08 ` [Buildroot] [PATCH 6/9] package/go: Enable MIPS support Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 7/9] package/go: Add HOST_GO_TOOLDIR Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 9/9] package/flannel: Set go env variables Geoff Levand
2016-05-12 0:08 ` [Buildroot] [PATCH 8/9] package/go: Build special host binaries Geoff Levand
2016-05-12 14:34 ` Thomas Petazzoni
2016-05-12 17:12 ` Geoff Levand
2016-05-12 0:15 ` [Buildroot] [PATCH 0/9] Fixes for go language support Christian Stewart
2016-05-12 14:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512161252.7471bf1e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox