From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libinput: remove unneeded patch
Date: Fri, 13 May 2016 16:48:18 +0300 [thread overview]
Message-ID: <20160513134818.GU2419@tarshish> (raw)
In-Reply-To: <20160513152314.19eebd42@free-electrons.com>
Hi Thomas,
On Fri, May 13, 2016 at 03:23:14PM +0200, Thomas Petazzoni wrote:
> On Fri, 13 May 2016 10:56:25 +0300, Baruch Siach wrote:
> > On Fri, May 13, 2016 at 09:09:52AM +0300, Baruch Siach wrote:
> > > The log_msg symbol conflict was fixed in libevdev commit e4c315fc1603 (Rename
> > > symbols leaking from static library to avoid name clashes, 2014-08-18) that
> > > was included in version 1.3. Remove the patch that used to fix this issue.
> >
> > I meant libevdev version in this last line, since it's a libevdev commit.
> > We're at 1.4.6 on that.
>
> You're already saying "libevdev" in your commit log. But the fact that
> you're removing a patch from libinput is not clear. I guess it's
> because libinput links against libevdev, but this should be made
> clearer in your commit message.
I see. It's just that the patch being removed itself says:
This fixes a conflict between libevdev and libinput on the definition
of the log_msg() symbol.
So I thought is should be self evident.
Should I respin with a clearer commit log?
Thanks for reviewing,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-05-13 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 6:09 [Buildroot] [PATCH] libinput: remove unneeded patch Baruch Siach
2016-05-13 7:40 ` Peter Korsgaard
2016-05-13 7:56 ` Baruch Siach
2016-05-13 13:23 ` Thomas Petazzoni
2016-05-13 13:48 ` Baruch Siach [this message]
2016-05-13 13:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513134818.GU2419@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox