From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Mon, 16 May 2016 09:36:41 +0300 Subject: [Buildroot] [PATCH] libinput: fix missing static_assert symbol In-Reply-To: <20160515135505.71404da2@gmx.net> References: <9c014a2f0264db4085efccf537f76e8f1993c27b.1463282640.git.baruch@tkos.co.il> <20160515053404.GA658@tarshish> <20160515094941.7402c3fa@gmx.net> <20160515135505.71404da2@gmx.net> Message-ID: <20160516063641.GE2583@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Peter, On Sun, May 15, 2016 at 01:55:05PM +0200, Peter Seiderer wrote: > On Sun, 15 May 2016 09:49:41 +0200, Peter Seiderer > wrote: > > On Sun, 15 May 2016 08:34:04 +0300, Baruch Siach > > wrote: > > > On Sun, May 15, 2016 at 06:24:00AM +0300, Baruch Siach wrote: > > > > static_assert() in from C++. Don't use it in C code. > > > > > > This is wrong. As upstream developer Jonas ?dahl pointed out, C11 also defines > > > static_assert as a convenience macro for _Static_assert. uClibc{,-ng} however > > > that does not provide this macro. Would it make sense to disable libinput for > > > uClibc{,-ng}? > > > > Or honor the second part of Jonas answer [1]: '... or define a no-op fallback > > when it is not defined.' > > > > Seems a less radical solution than disable complete package (plus dependencies) > > for uClibc because of a minor issue? > > Thinking more about it, I think your suggested patch is a good enough solution > for buildroot purpose, so you can add my > > Reviewed-by: Peter Seiderer > > in case you change the patch descriptions to mention it is not a C++ thing but > static_assert is from C11 standard [2] (and besides your patch changes the logic > from compile time error to possible run time error (dependent on NDEBUG flag)... That alone is a good enough reason to not apply this patch IMO. Upstream has a better suggestion along the line of no-op fallback. I plan to respin with that fix instead Thanks for reviewing, baruch > [2] http://en.cppreference.com/w/c/error/static_assert > > [1] > > https://lists.freedesktop.org/archives/wayland-devel/2016-May/028877.html -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -