From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix config.mak.uname to allow cross-compilation
Date: Sun, 22 May 2016 22:29:42 +0200 [thread overview]
Message-ID: <20160522222942.37041c37@free-electrons.com> (raw)
In-Reply-To: <1463948643-21344-2-git-send-email-mc5686@mclink.it>
Hello,
Thanks for your contribution.
On Sun, 22 May 2016 22:24:03 +0200, Mauro Condarelli wrote:
> Current implementation imperatively sets variables from "uname" output.
> This breaks cross-compilation because uname is run on host while target
> configuration may be different.
>
> Make current behavior a non-imperative default, so it's possible to
> force different values setting make variables.
>
> To cross-compile it will be necessary to explicitly set the various
> uname_X variables to values compatible with target.
> No change is needed with normal host compilation.
> Patch is trivial.
>
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
> ---
> config.mak.uname | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
This patch cannot be applied, as it is a patch against Git directly,
while you should send patches against Buildroot. I.e, a patch that adds
a patch.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-22 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 20:24 [Buildroot] [PATCH 1/1] Fix config.mak.uname to allow cross-compilation Mauro Condarelli
2016-05-22 20:24 ` Mauro Condarelli
2016-05-22 20:29 ` Thomas Petazzoni [this message]
2016-05-22 20:40 ` Mauro Condarelli
2016-05-22 20:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522222942.37041c37@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).