Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/scripts/apply-patches.sh: handle tar and mkdir failures
Date: Wed, 25 May 2016 17:11:45 +0200	[thread overview]
Message-ID: <20160525171145.6d8950d9@free-electrons.com> (raw)
In-Reply-To: <1464178439-3333-1-git-send-email-sebastien.szymanski@armadeus.com>

Hello,

On Wed, 25 May 2016 14:13:59 +0200, S?bastien Szymanski wrote:
> With several archives in a space-separated list of patches, if one archive
> cannot be untar (i.e because it is not readable), Buildroot keeps going instead
> of aborting. Fix this by checking the tar return code.
> While at it, check if the unpack archive directory creation is successful.
> 
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  support/scripts/apply-patches.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks for the patch. One question though: are you actually using the
capability of Buildroot to take a tarball, and apply the patches that
it contains? If so, for what use case?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-05-25 15:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 12:13 [Buildroot] [PATCH 1/1] support/scripts/apply-patches.sh: handle tar and mkdir failures Sébastien Szymanski
2016-05-25 15:11 ` Thomas Petazzoni [this message]
2016-05-25 16:04   ` Sébastien Szymanski
2016-07-05 10:40 ` Romain Naour
2016-07-05 11:05 ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525171145.6d8950d9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox