Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/6] package/flannel: Add BR2_TOOLCHAIN_HAS_THREADS
Date: Thu, 26 May 2016 21:15:25 +0200	[thread overview]
Message-ID: <20160526211525.32e8b448@free-electrons.com> (raw)
In-Reply-To: <627469f0b7b4e604da3a5ab3ef721f138a1c95a8.1464286518.git.geoff@infradead.org>

Hello,

On Thu, 26 May 2016 18:21:33 +0000, Geoff Levand wrote:
> flannel uses the cgo package, so needs a toolchain with thread
> support.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  package/flannel/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/flannel/Config.in b/package/flannel/Config.in
> index c6a84ef..32d9f66 100644
> --- a/package/flannel/Config.in
> +++ b/package/flannel/Config.in
> @@ -1,6 +1,10 @@
> +comment "flannel needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

This also needs:

	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS

so that the comment doesn't show up on architectures that anyway don't
support Go.

I've fixed that when applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-05-26 19:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 18:21 [Buildroot] [PATCH v3 0/6] Fixes for go language support Geoff Levand
2016-05-26 18:21 ` [Buildroot] [PATCH v3 2/6] package/go: Add HOST_GO_TARGET_ENV Geoff Levand
2016-05-26 18:21 ` [Buildroot] [PATCH v3 1/6] package/go: Build host tools with host CC Geoff Levand
2016-05-26 18:21 ` [Buildroot] [PATCH v3 5/6] package/flannel: Add BR2_TOOLCHAIN_HAS_THREADS Geoff Levand
2016-05-26 19:15   ` Thomas Petazzoni [this message]
2016-05-28 13:41   ` Thomas Petazzoni
2016-05-28 15:50     ` Waldemar Brodkorb
2016-05-31 20:47     ` Geoff Levand
2016-05-31 20:56       ` Thomas Petazzoni
2016-06-05  7:00         ` Waldemar Brodkorb
2016-05-26 18:21 ` [Buildroot] [PATCH v3 4/6] package/go: Add HOST_GO_CGO_ENABLED Geoff Levand
2016-05-26 19:14   ` Thomas Petazzoni
2017-10-03 10:05   ` Angelo Compagnucci
2016-05-26 18:21 ` [Buildroot] [PATCH v3 6/6] package/go: Set file timestamp Geoff Levand
2016-05-26 18:21 ` [Buildroot] [PATCH v3 3/6] package/flannel: Use HOST_GO_TARGET_ENV Geoff Levand
2016-05-26 19:14 ` [Buildroot] [PATCH v3 0/6] Fixes for go language support Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526211525.32e8b448@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox