From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/3] runc: new package
Date: Fri, 27 May 2016 07:25:20 +0200 [thread overview]
Message-ID: <20160527072520.63f30cf8@free-electrons.com> (raw)
In-Reply-To: <1464324777-5364-2-git-send-email-christian@paral.in>
Hello,
On Thu, 26 May 2016 21:52:55 -0700, Christian Stewart wrote:
> diff --git a/package/runc/Config.in b/package/runc/Config.in
> new file mode 100644
> index 0000000..7d0c951
> --- /dev/null
> +++ b/package/runc/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_RUNC
> + bool "runc"
> + depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + help
> + runC is a CLI tool for spawning and running containers
> + according to the OCP specification.
> +
> + https://github.com/opencontainers/runc
> +
> +comment "runc needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
The comment also needs the dependency on
BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS in order to not show the comment on
architectures on which Go support is anyway not available.
> +RUNC_GOPATH = "$(@D)/Godeps/_workspace"
> +RUNC_MAKE_ENV = $(HOST_GO_TARGET_ENV) \
> + CGO_ENABLED=1 \
> + GOBIN="$(@D)/bin" \
> + GOPATH="$(RUNC_GOPATH)"
> +
> +RUNC_GLDFLAGS = \
> + -X main.gitCommit=$(RUNC_VERSION_COMMIT) \
As asked in my review of the previous version, what about using
RUNC_VERSION here?
Other than that, looks good to me.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-27 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 4:52 [Buildroot] [PATCH v4 0/3] Add docker engine support Christian Stewart
2016-05-27 4:52 ` [Buildroot] [PATCH v4 1/3] runc: new package Christian Stewart
2016-05-27 5:25 ` Thomas Petazzoni [this message]
2016-05-27 4:52 ` [Buildroot] [PATCH v4 2/3] docker-containerd: " Christian Stewart
2016-05-27 5:27 ` Thomas Petazzoni
2016-05-27 7:02 ` Christian Stewart
2016-05-27 19:49 ` Thomas Petazzoni
2016-05-27 4:52 ` [Buildroot] [PATCH v4 3/3] docker-engine: " Christian Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527072520.63f30cf8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox