From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Van Dijck Date: Tue, 31 May 2016 11:35:37 +0200 Subject: [Buildroot] [PATCH] build: fix umask test In-Reply-To: <87wpmazn0i.fsf@dell.be.48ers.dk> References: <20160530070635.GA27560@airbook.vandijck-laurijssen.be> <87mvn82d50.fsf@dell.be.48ers.dk> <87inxw2cnt.fsf@dell.be.48ers.dk> <20160530111740.14c24236@free-electrons.com> <20160530095319.GA5804@airbook.vandijck-laurijssen.be> <87a8j73lz2.fsf@dell.be.48ers.dk> <20160530210928.GA19307@airbook.vandijck-laurijssen.be> <744ed421-d308-297d-a497-251a7756c0d2@mind.be> <20160531074348.GA26685@airbook> <87wpmazn0i.fsf@dell.be.48ers.dk> Message-ID: <20160531093537.GD26685@airbook> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net > >>>>> "Kurt" == Kurt Van Dijck writes: > > >> > > >> > I see, but how would that help when bash is not on the system? > >> > Is bash a prerequisite? > >> > >> Yes, bash is a prerequisite. Some of our own scripts are bash scripts. > >> Moreover, quite a few packages just assume that the shell is bash. Requiring > >> bash and setting is as SHELL is the simplest way to handle that. > > > The Makefile only recommends /bin/bash, it falls back to 'sh' when bash > > is not present. > > Yes, but support/dependencies/dependencies.sh checks for bash and bails > out if not available. I wasn't aware of this :-) I already sent out a v2 of the patch which makes it shell-independant. Kurt