From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs: new configuration for i.MX6UL Pico board
Date: Tue, 31 May 2016 22:16:50 +0200 [thread overview]
Message-ID: <20160531221650.385eccad@free-electrons.com> (raw)
In-Reply-To: <1463601264-16293-1-git-send-email-festevam@gmail.com>
Hello,
On Wed, 18 May 2016 16:54:24 -0300, Fabio Estevam wrote:
> Add support for Technexion's i.MX6UL Pico board.
>
> For information about this board, please visit:
> http://www.wandboard.org/images/hobbit/hobbitboard-imx6ul-reva1.pdf
>
> Currently two patches are needed, but in the future they can be removed
> when we switch to kernel 4.7 and U-boot 2016.07 versions.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
This generally looks good, but we generally like when a readme.txt is
added to indicate how to quickly setup the board to use the Buildroot
image.
> diff --git a/board/technexion/imx6ulpico/post-image.sh b/board/technexion/imx6ulpico/post-image.sh
> new file mode 100755
> index 0000000..b0917fc
> --- /dev/null
> +++ b/board/technexion/imx6ulpico/post-image.sh
> @@ -0,0 +1,15 @@
> +#!/usr/bin/env bash
> +
> +GENIMAGE_CFG="board/technexion/imx6ulpico/genimage.cfg"
Maybe use the $(dirname $0) trick ?
Other than that, looks good to me.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-31 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 19:54 [Buildroot] [PATCH] configs: new configuration for i.MX6UL Pico board Fabio Estevam
2016-05-31 20:16 ` Thomas Petazzoni [this message]
2016-07-15 13:00 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531221650.385eccad@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox