From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] libamcodec: new Package
Date: Wed, 1 Jun 2016 15:33:23 +0200 [thread overview]
Message-ID: <20160601153323.2e8e8b00@free-electrons.com> (raw)
In-Reply-To: <574EE26C.8070302@imgtec.com>
Hello,
On Wed, 1 Jun 2016 14:26:04 +0100, Vicente Olivert Riera wrote:
> The fist time I saw the PREFIX stuff I thought that it was wrong,
> because that's something you use when you are going to install the
> package, like DESTDIR. But looking at the Makefiles I've seen this
> package uses the PREFIX (and M_PREFIX) vars to build the includes and
> library paths. So if we don't pass PREFIX and M_PREFIX then the Makefile
> will do "-L/usr/lib and -I/usr/include" instead of
> "-L/br/output/staging/usr/lib -I/br/output/staging/usr/include".
Alright, thanks for the explanation. It's indeed a non-standard use of
PREFIX, so it should simply be explained by a short comment above the
<pkg>_BUILD_CMDS variable.
Thanks again for the review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-01 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 10:27 [Buildroot] [PATCH 1/3] libamcodec: new Package Dagg
2016-06-01 10:27 ` [Buildroot] [PATCH 2/3] select libamlogic for odroidc2 boards Dagg
2016-06-01 10:27 ` [Buildroot] [PATCH 3/3] allow kodi to select libamlogic if set Dagg
2016-06-04 21:12 ` Bernd Kuhls
2016-06-01 12:16 ` [Buildroot] [PATCH 1/3] libamcodec: new Package Thomas Petazzoni
2016-06-01 20:52 ` daggs
2016-06-01 21:05 ` Thomas Petazzoni
2016-06-01 21:16 ` daggs
2016-06-01 21:28 ` Thomas Petazzoni
2016-06-02 5:11 ` daggs
2016-06-28 11:24 ` Peter Korsgaard
2016-06-28 11:18 ` Peter Korsgaard
2016-06-04 13:02 ` Thomas Petazzoni
2016-06-04 15:02 ` daggs
2016-06-04 15:53 ` Yann E. MORIN
2016-06-05 5:43 ` daggs
2016-06-01 12:53 ` Vicente Olivert Riera
2016-06-01 13:20 ` Thomas Petazzoni
2016-06-01 13:26 ` Vicente Olivert Riera
2016-06-01 13:33 ` Thomas Petazzoni [this message]
2016-06-01 20:58 ` daggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601153323.2e8e8b00@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox