From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/8 RFC] docs/manual: documents the golang-package infrastructure
Date: Wed, 1 Jun 2016 22:28:56 +0200 [thread overview]
Message-ID: <20160601222856.73ec3be2@free-electrons.com> (raw)
In-Reply-To: <1454369465-4804-6-git-send-email-ludovic.guegan@gmail.com>
Hello,
On Tue, 2 Feb 2016 00:31:02 +0100, Ludovic Guegan wrote:
> +01: ################################################################################
> +02: #
> +03: # foo-bar
> +04: #
> +05: ################################################################################
> +06:
> +07: FOO_LICENSE = MIT
> +08: FOO_VERSION = release_1.0
> +09: FOO_SITE = $(call github,foo,bar,$(FOO_VERSION))
> +10: FOO_EXTRACT_DIR = $(@D)/src/github.com/foo/bar
Shouldn't this be just where the symlink should be created in the Go
workspace ?
FOO_WORKSPACE_LOCATION or something like that?
> +11:
> +12: FOO_DEPS += $(call fetch-golang-package, github.com/other/package, \
> +13: 1f22c0103821b9390939b6776727195525381532)
As said in my review of patch 4/8, it is not good when one package
fetches another. github.com/other/package should be another package.
> +14:
> +16: FOO_BUILD_PACKAGES = github.com/foo/bar/cmd/foo
Couldn't this be expressed in terms of FOO_WORKSPACE_LOCATION, like:
FOO_BUILD_PACKAGES = $(FOO_WORKSPACE_LOCATION)/cmd/foo
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-01 20:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 23:30 [Buildroot] [PATCH 0/8 RFC] Adding a Go package infrastructure Ludovic Guegan
2016-02-01 23:30 ` [Buildroot] [PATCH 1/8 RFC] package/golang: create Go 1.5 host compiler package Ludovic Guegan
2016-02-01 23:30 ` [Buildroot] [PATCH 2/8 RFC] package/golang-gb: create gb package to build and fetch go packages Ludovic Guegan
2016-06-01 20:17 ` Thomas Petazzoni
2016-02-01 23:31 ` [Buildroot] [PATCH 3/8 RFC] package/pkg-generic.mk: allow custom extract directory Ludovic Guegan
2016-06-01 20:19 ` Thomas Petazzoni
2016-02-01 23:31 ` [Buildroot] [PATCH 4/8 RFC] package/pkg-golang.mk: infrastructure for Go packages Ludovic Guegan
2016-06-01 20:26 ` Thomas Petazzoni
2016-02-01 23:31 ` [Buildroot] [PATCH 5/8 RFC] docs/manual: documents the golang-package infrastructure Ludovic Guegan
2016-06-01 20:28 ` Thomas Petazzoni [this message]
2016-02-01 23:31 ` [Buildroot] [PATCH 6/8 RFC] package/rtop: add rtop package in Go Ludovic Guegan
2016-02-01 23:31 ` [Buildroot] [PATCH 7/8 RFC] package/embd: add embd package (embedded programming framework) Ludovic Guegan
2016-02-01 23:31 ` [Buildroot] [PATCH 8/8 RFC] package/bolt: add bolt package (persistent key-value store) Ludovic Guegan
2016-06-01 20:14 ` [Buildroot] [PATCH 0/8 RFC] Adding a Go package infrastructure Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601222856.73ec3be2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox