From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] package/nodejs: Add NODEJS_CONF_OPTS
Date: Sat, 4 Jun 2016 12:06:45 +0200 [thread overview]
Message-ID: <20160604100645.GA3852@free.fr> (raw)
In-Reply-To: <1464981346-11741-1-git-send-email-martin@barkynet.com>
Martin, All,
On 2016-06-03 20:15 +0100, Martin Bark spake thusly:
> Most packages in buildroot pass a FOO_CONF_OPTS variable into the
> configure script. Transition nodejs to follow this convention.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
> ---
> package/nodejs/nodejs.mk | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 0329299..b78ba79 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -13,6 +13,12 @@ HOST_NODEJS_DEPENDENCIES = host-python host-zlib
> NODEJS_LICENSE = MIT (core code); MIT, Apache and BSD family licenses (Bundled components)
> NODEJS_LICENSE_FILES = LICENSE
>
> +NODEJS_CONF_OPTS = --without-snapshot \
> + --shared-zlib \
> + --without-dtrace \
> + --without-etw \
> + --dest-os=linux
When we have multi-line variables, I prefer that we write all options on
multi-line and none on the first line:
NODEJS_CONF_OPTS = \
--without-snapshot \
--shared-zlib \
--without-dtrace \
--without-etw \
--dest-os=linux
Otehrwise, looks good:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_OPENSSL),y)
> NODEJS_DEPENDENCIES += openssl
> endif
> @@ -97,18 +103,14 @@ define NODEJS_CONFIGURE_CMDS
> PYTHON=$(HOST_DIR)/usr/bin/python2 \
> $(HOST_DIR)/usr/bin/python2 ./configure \
> --prefix=/usr \
> - --without-snapshot \
> - --shared-zlib \
> $(if $(BR2_PACKAGE_OPENSSL),--shared-openssl,--without-ssl) \
> $(if $(BR2_PACKAGE_ICU),--with-intl=system-icu,--with-intl=none) \
> $(if $(BR2_PACKAGE_NODEJS_NPM),,--without-npm) \
> - --without-dtrace \
> - --without-etw \
> --dest-cpu=$(NODEJS_CPU) \
> $(if $(NODEJS_ARM_FP),--with-arm-float-abi=$(NODEJS_ARM_FP)) \
> $(if $(NODEJS_MIPS_ARCH_VARIANT),--with-mips-arch-variant=$(NODEJS_MIPS_ARCH_VARIANT)) \
> $(if $(NODEJS_MIPS_FPU_MODE),--with-mips-fpu-mode=$(NODEJS_MIPS_FPU_MODE)) \
> - --dest-os=linux \
> + $(NODEJS_CONF_OPTS) \
> )
> endef
>
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-06-04 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:15 [Buildroot] [PATCH 1/4] package/nodejs: Add NODEJS_CONF_OPTS Martin Bark
2016-06-03 19:15 ` [Buildroot] [PATCH 2/4] package/nodejs: Update icu to use NODEJS_CONF_OPTS Martin Bark
2016-06-04 10:07 ` Yann E. MORIN
2016-06-03 19:15 ` [Buildroot] [PATCH 3/4] package/nodejs: Update openssl " Martin Bark
2016-06-04 10:07 ` Yann E. MORIN
2016-06-03 19:15 ` [Buildroot] [PATCH 4/4] package/nodejs: Update npm " Martin Bark
2016-06-04 10:08 ` Yann E. MORIN
2016-06-05 18:14 ` Martin Bark
2016-06-04 10:06 ` Yann E. MORIN [this message]
2016-06-04 12:33 ` [Buildroot] [PATCH 1/4] package/nodejs: Add NODEJS_CONF_OPTS Thomas Petazzoni
2016-06-04 12:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160604100645.GA3852@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox