Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod
Date: Mon, 6 Jun 2016 23:28:58 +0200	[thread overview]
Message-ID: <20160606212858.GC3706@free.fr> (raw)
In-Reply-To: <87k2i2ghfq.fsf@dell.be.48ers.dk>

Peter, All,

On 2016-06-06 23:01 +0200, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > When that was added (in 975e30b, fs/squashfs: fix image file
>  > permissions), the reasons were not quite explicit.
> 
> The git hash is wrong, it was 3975e30b9.

Good catch!

Regards,
Yann E. MORIN.

>  > We are now forcing the umask, and various tests have shown that the mode
>  > on the generated image file are correct without the chmod.
> 
>  > Remove it.
> 
>  > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  > Cc: Peter Korsgaard <peter@korsgaard.com>
> 
> otherwise it looks good.
> 
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
> 
> > ---
>  >  fs/squashfs/squashfs.mk | 1 -
>  >  1 file changed, 1 deletion(-)
> 
>  > diff --git a/fs/squashfs/squashfs.mk b/fs/squashfs/squashfs.mk
>  > index eadbb8f..c4d9ca5 100644
>  > --- a/fs/squashfs/squashfs.mk
>  > +++ b/fs/squashfs/squashfs.mk
>  > @@ -27,7 +27,6 @@ endif
>  >  define ROOTFS_SQUASHFS_CMD
>  >  	$(HOST_DIR)/usr/bin/mksquashfs $(TARGET_DIR) $@ -noappend \
>  >  		$(ROOTFS_SQUASHFS_ARGS)
>  > -	chmod 0644 $@
>  >  endef
>  
>  >  $(eval $(call ROOTFS_TARGET,squashfs))
>  > -- 
>  > 2.7.4
> 
> 
> 
> -- 
> Venlig hilsen,
> Peter Korsgaard 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-06-06 21:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 20:43 [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 1/7] core/pkg-utils: add macro to escape-and-printf Yann E. MORIN
2016-06-06 21:07   ` Thomas Petazzoni
2016-06-06 21:25     ` Yann E. MORIN
2016-06-06 22:54       ` Arnout Vandecappelle
2016-06-06 20:43 ` [Buildroot] [PATCH 2/7] fs: properly escape commands when generating fakeroot script Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 3/7] fs/cloop: split long line Yann E. MORIN
2016-06-06 21:19   ` Thomas Petazzoni
2016-06-06 20:43 ` [Buildroot] [PATCH 4/7] fs/jffs2: split commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 5/7] fs/squashfs: " Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 6/7] fs/ubifs: fix the UBI commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod Yann E. MORIN
2016-06-06 21:01   ` Peter Korsgaard
2016-06-06 21:28     ` Yann E. MORIN [this message]
2016-06-06 21:06   ` Thomas Petazzoni
2016-06-06 21:16     ` Yann E. MORIN
2016-06-07 12:51       ` Peter Korsgaard
2016-06-07 19:12         ` Yann E. MORIN
2016-06-07 20:27 ` [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606212858.GC3706@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox