Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/8 v3] core: add support for package help (branch yem/help)
Date: Tue, 7 Jun 2016 22:18:44 +0200	[thread overview]
Message-ID: <20160607221844.45eb8b34@free-electrons.com> (raw)
In-Reply-To: <cover.1465056706.git.yann.morin.1998@free.fr>

Hello,

On Sat,  4 Jun 2016 18:30:49 +0200, Yann E. MORIN wrote:

> Yann E. MORIN (8):
>       core/pkg-generic: add support for package-defined help
>       core: name the package before its help text
>       core/pkg-utils: add a macro to pretty-print a help entry
>       package/busybox: use the generic help rules
>       linux: use the generic help rules
>       package/uclibc: use the generic help rules
>       boot/barebox: use the generic help rules
>       core: use the print-help macro to print the main help

This last commit made me realize that the helper is a bad idea:

 1/ It makes the code longer in number of lines.

 2/ It makes it harder to read.

So, as discussed on IRC, I've reworked your patches to drop the helper
that pretty-print the help text, and simply used the @echo calls in the
various packages.

So essentially, I've dropped patches 3/8 and 8/8, and I've reworked
patches 4, 5, 6 and 7 to not use the helper.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-07 20:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 16:30 [Buildroot] [PATCH 0/8 v3] core: add support for package help (branch yem/help) Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 1/8 v3] core/pkg-generic: add support for package-defined help Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 2/8 v3] core: name the package before its help text Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 3/8 v3] core/pkg-utils: add a macro to pretty-print a help entry Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 4/8 v3] package/busybox: use the generic help rules Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 5/8 v3] linux: " Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 6/8 v3] package/uclibc: " Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 7/8 v3] boot/barebox: " Yann E. MORIN
2016-06-04 16:30 ` [Buildroot] [PATCH 8/8 v3] core: use the print-help macro to print the main help Yann E. MORIN
2016-06-07 20:18 ` Thomas Petazzoni [this message]
2016-06-07 20:22   ` [Buildroot] [PATCH 0/8 v3] core: add support for package help (branch yem/help) Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607221844.45eb8b34@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox