Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python-meson: new package
Date: Thu, 9 Jun 2016 21:28:20 +0200	[thread overview]
Message-ID: <20160609212820.6816f3db@free-electrons.com> (raw)
In-Reply-To: <20160609195954.52b9a527@itchy>

Hello Eric,

On Thu, 9 Jun 2016 19:59:54 +0200, Eric Le Bihan wrote:

> It is true that all the "docs/manual/adding-packages*.txt" files refer
> to a dedicated infrastructure, whereas what is needed here is an
> example of Makefile using the generic-package infrastructure. There is
> an exception to the rule, though: docs/manual/adding-packages-gettext.txt.
> 
> So, IMHO, a new document named "docs/manual/adding-packages-meson.txt" should 
> fit.

Sounds good.

> However, I could provide a real package infrastructure named "meson-package",
> but as stated in the discussion about adding support for Cargo [1] (the Rust
> package manager), to provide such infrastructure, at least one package using
> it should also be provided (it is sensible to have a working example of 
> the infrastructure).

I would not say one, but at least 4-5 packages, with a pretty good
confidence that more packages would be added later on.

> > > +
> > > +define HOST_PYTHON_MESON_REMOVE_GUI_TOOL
> > > +	rm -f $(HOST_DIR)/usr/bin/mesongui.py
> > > +endef    
> > 
> > Not sure removing stuff from the host variant is really useful.  
> 
> This program needs PyQt5, which may not be installed by default by the
> most popular GNU/Linux distributions. The user may be tempted to use
> it: the execution will fail and this may result in an unnecessary
> Buildroot bug report. To avoid this, I chose to remove it.

We don't bother doing such cleanup steps for host packages, I really
don't think it's worth it.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-06-09 19:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 13:34 [Buildroot] [PATCH 0/2] Ninja, Meson: new build systems Eric Le Bihan
2016-06-04 13:34 ` [Buildroot] [PATCH 1/2] ninja: new package Eric Le Bihan
2016-06-04 15:50   ` Bernd Kuhls
2016-06-04 18:03     ` Eric Le Bihan
2016-06-08 20:17       ` Thomas Petazzoni
2016-06-08 20:16   ` Thomas Petazzoni
2016-06-04 13:34 ` [Buildroot] [PATCH 2/2] python-meson: " Eric Le Bihan
2016-06-08 20:22   ` Thomas Petazzoni
2016-06-09 17:59     ` Eric Le Bihan
2016-06-09 19:28       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609212820.6816f3db@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox