From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/cups: add _PRE_CONFIGURE_HOOKS for proper autoconf
Date: Sun, 12 Jun 2016 22:07:37 +0200 [thread overview]
Message-ID: <20160612220737.69a84129@free-electrons.com> (raw)
In-Reply-To: <1464543503-9057-1-git-send-email-bernd.kuhls@t-online.de>
Hello,
On Sun, 29 May 2016 19:38:23 +0200, Bernd Kuhls wrote:
> cups uses only autoconf, also using autoheader is broken:
> https://github.com/apple/cups/issues/4667#issuecomment-197689571
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> I wrote this patch while trying to fix
> http://autobuild.buildroot.net/results/70d/70d147fcac588610521974b8f7384e710a9a6d41/
> which would end up in a major rewrite of the build system, so I
> cancelled my attempt. Nonetheless I think we should have this patch
> so future patches to configure.in will be easier.
>
> ...01-Remove-man-from-BUILDDIRS-in-configure.patch | 27 ++++++++++------------
> package/cups/cups.mk | 7 ++++++
> 2 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/package/cups/0001-Remove-man-from-BUILDDIRS-in-configure.patch b/package/cups/0001-Remove-man-from-BUILDDIRS-in-configure.patch
> index c0e87a4..af85ca8 100644
> --- a/package/cups/0001-Remove-man-from-BUILDDIRS-in-configure.patch
> +++ b/package/cups/0001-Remove-man-from-BUILDDIRS-in-configure.patch
> @@ -1,21 +1,18 @@
> -From a77bb18a5584bb23687ed3c522dbd91a9987d5a7 Mon Sep 17 00:00:00 2001
> -From: Olivier Schonken <olivier.schonken@gmail.com>
> -Date: Wed, 20 Jan 2016 22:13:11 +0200
> -Subject: [PATCH] Remove man from BUILDDIRS in configure
> +From 6bc1d15250841cf17d307cfb4f35c960c23d8797 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd.kuhls@t-online.de>
> +Date: Sun, 29 May 2016 19:31:50 +0200
> +Subject: [PATCH 1/1] Remove man from BUILDDIRS in configure
The 1/1 is not needed here, please generate patches using "git
format-patch -N".
Applied with this fixed!
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-06-12 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 17:38 [Buildroot] [PATCH 1/1] package/cups: add _PRE_CONFIGURE_HOOKS for proper autoconf Bernd Kuhls
2016-06-12 20:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160612220737.69a84129@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox