From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable
Date: Sat, 18 Jun 2016 22:58:01 +0200 [thread overview]
Message-ID: <20160618225801.2a290a33@free-electrons.com> (raw)
In-Reply-To: <1466268206-62239-1-git-send-email-Vincent.Riera@imgtec.com>
Hello,
On Sat, 18 Jun 2016 17:43:26 +0100, Vicente Olivert Riera wrote:
> # sparc64 needs -fPIC instead of -fpic
> ifeq ($(BR2_sparc64),y)
> -ELFUTILS_CFLAGS += -fPIC
> +ELFUTILS_CFLAGS = -fPIC
This change is wrong, += should be kept here.
> # elfutils gets confused when lfs mode is forced, so don't
> -ELFUTILS_CFLAGS = $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> +ELFUTILS_CFLAGS += $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
Either you change to += like you propose, or you move the assignment
earlier. Changing to += is fine for me, but you should not change the
conditional assignment to = in the sparc64 condition.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-18 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 16:43 [Buildroot] [PATCH] elfutils: do not override ELFUTILS_CFLAGS variable Vicente Olivert Riera
2016-06-18 20:58 ` Thomas Petazzoni [this message]
2016-06-19 8:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618225801.2a290a33@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox