From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Signed-off-by: PeterThompson <peter.macleod.thompson@gmail.com>
Date: Sun, 26 Jun 2016 14:57:06 +0200 [thread overview]
Message-ID: <20160626145706.6342d905@free-electrons.com> (raw)
In-Reply-To: <1466910144-17919-1-git-send-email-peter.macleod.thompson@gmail.com>
Hello,
As Baruch said, the first line of your commit should be:
sdl2_ttf: new package
On Sat, 25 Jun 2016 21:02:24 -0600, Peter Thompson wrote:
> From: PeterThompson <peter.macleod.thompson@gmail.com>
Please add a space between Peter and Thompson.
>
> sdl2_ttf created from sdl_ttf with minor changes for sdl2
>
> Signed-off-by: PeterThompson <peter.macleod.thompson@gmail.com>
Ditto.
> new file mode 100644
> index 0000000..8eb480f
> --- /dev/null
> +++ b/package/sdl2_ttf/sdl2_ttf.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# sdl2_ttf
> +#
> +################################################################################
> +
> +SDL2_TTF_VERSION = 2.0.14
> +SDL2_TTF_SOURCE = SDL2_ttf-$(SDL2_TTF_VERSION).tar.gz
> +SDL2_TTF_SITE = http://www.libsdl.org/projects/SDL_ttf/release
> +SDL2_TTF_LICENSE = zlib
> +SDL2_TTF_LICENSE_FILES = COPYING
> +
> +SDL2_TTF_INSTALL_STAGING = YES
> +SDL2_TTF_DEPENDENCIES = sdl2 freetype
> +SDL2_TTF_CONF_OPTS = \
> + --without-x \
> + --with-freetype-prefix=$(STAGING_DIR)/usr \
> + --with-sdl2-prefix=$(STAGING_DIR)/usr
> +
> +SDL2_TTF_MAKE_OPTS = INCLUDES="-I$(STAGING_DIR)/usr/include/SDL2" LDFLAGS="-L$(STAGING_DIR)/usr/lib"
The LDFLAGS should not be needed, as searching for libraries in
$(STAGING_DIR)/usr/lib is the default. Regarding the INCLUDES variable,
it's also a bit weird, since you're already passing
--with-sdl2-prefix=$(STAGING_DIR)/usr in CONF_OPTS.
Please include a blank line before the last variable definition and the
call to the autotools-package macro.
Finally, please add a hash file (see
https://buildroot.org/downloads/manual/manual.html#adding-packages-hash).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-26 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 3:02 [Buildroot] [PATCH 1/1] Signed-off-by: PeterThompson <peter.macleod.thompson@gmail.com> Peter Thompson
2016-06-26 12:57 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-26 3:03 Peter Thompson
2016-06-26 3:04 Peter Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626145706.6342d905@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox