Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package: add Odroid BL bootloader binaries
Date: Tue, 28 Jun 2016 03:03:03 +0900	[thread overview]
Message-ID: <20160627180303.GL424@jack.zhora.eu> (raw)
In-Reply-To: <20160626221048.02818b93@free-electrons.com>

Hi Thomas,

> > The above files are provided by the hardkernel u-boot from
> > 
> >  https://github.com/hardkernel/u-boot/tree/odroidxu3-v2012.07
> 
> So the source code for those binary files is not available at all?

Unfortunately not, it is not even available to me :(

> > +config BR2_PACKAGE_ODROID_XU_BL
> > +	bool "odroid-xu-bl"
> 
> 	depends on BR2_arm
> 
> would be good to have here

OK.

> Also, I think this package should be included in the Bootloaders menu
> rather than the firmware menu. Maybe we should name it
> odroid-xu-bootloader or odroid-xu-boot so that it is clear what it does.

OK.

> > +ODROID_XU_BL_VERSION = odroidxu3-v2012.07
> > +ODROID_XU_BL_SITE = $(call github,hardkernel,u-boot,$(ODROID_XU_BL_VERSION))
> 
> It's a bit annoying that we end up downloading an entire U-Boot source
> tree, and in fact not use it except for those 3 files.
> 
> In fact, why don't you simply build this U-Boot version with the U-Boot
> package that already exists in Buildroot, and then use:

It is indeed annoying: I don't like the idea of

 1. downloading two u-boot
 2. download u-boot for just two files.

But, on the other hand, I don't like the hardkernel u-boot
either. I think it's old, ugly and too hacky; as a buildroot
user, I would like as much as I can to use mainline software.
Besides, the cool thing of this board is that it is well
supported both from the Linux Kernel and u-boot.

How about creating a new repository with just these three files?
If it sounds good, I will check with the licensing, even though I
don't thing it will be a problem.

Thanks a lot,
Andi

  reply	other threads:[~2016-06-27 18:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 14:07 [Buildroot] [PATCH 0/2] Odroid XU4 support Andi Shyti
2016-06-26 14:07 ` [Buildroot] [PATCH 1/2] package: add Odroid BL bootloader binaries Andi Shyti
2016-06-26 20:10   ` Thomas Petazzoni
2016-06-27 18:03     ` Andi Shyti [this message]
     [not found]     ` <20160627155236.GI424@jack.zhora.eu>
2016-06-30  7:58       ` Thomas Petazzoni
2016-06-26 14:07 ` [Buildroot] [PATCH 2/2] board: add support for the Odroid XU4 board Andi Shyti
2016-06-26 14:14   ` Baruch Siach
2016-06-27 17:02     ` Andi Shyti
2016-06-26 20:22   ` Thomas Petazzoni
2016-06-27 18:04     ` Andi Shyti
2016-06-26 19:51 ` [Buildroot] [PATCH 0/2] Odroid XU4 support Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627180303.GL424@jack.zhora.eu \
    --to=andi.shyti@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox