Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/24] jsmin: drop unused host variant
Date: Wed, 29 Jun 2016 15:56:53 +0200	[thread overview]
Message-ID: <20160629155653.326794ba@free-electrons.com> (raw)
In-Reply-To: <1467207991-4905-7-git-send-email-julien.floret@6wind.com>

Hello,

On Wed, 29 Jun 2016 15:46:13 +0200, Julien Floret wrote:
> Signed-off-by: Julien Floret <julien.floret@6wind.com>
> ---
>  package/jsmin/jsmin.mk | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/package/jsmin/jsmin.mk b/package/jsmin/jsmin.mk
> index a66ba7158245..42344c9c8674 100644
> --- a/package/jsmin/jsmin.mk
> +++ b/package/jsmin/jsmin.mk
> @@ -17,13 +17,4 @@ define JSMIN_INSTALL_TARGET_CMDS
>  	$(INSTALL) -m 0755 -D $(@D)/jsmin $(TARGET_DIR)/usr/bin/jsmin
>  endef
>  
> -define HOST_JSMIN_BUILD_CMDS
> -	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) jsmin
> -endef
> -
> -define HOST_JSMIN_INSTALL_CMDS
> -	$(INSTALL) -m 0755 -D $(@D)/jsmin $(HOST_DIR)/usr/bin/jsmin
> -endef
> -
>  $(eval $(generic-package))
> -$(eval $(host-generic-package))

This package (and its host variant) was added by Peter Korsgaard. I
guess the JS minimizer is useful on the host, when building other
packages, like web sites and their javascript code. Such packages are
generally not in Buildroot upstream, which is why we don't have a
dependency on host-jsmin anywhere.

Should we add a menuconfig entry, even though it's merely a build
dependency?

Peter?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-06-29 13:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 13:46 [Buildroot] [PATCH 00/24] Drop unused host packages Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 01/24] x11r7: drop unused host variants Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 02/24] sepolgen: drop unused host package Julien Floret
2016-06-29 13:53   ` Thomas Petazzoni
2016-06-29 13:46 ` [Buildroot] [PATCH 03/24] attr: drop unused host variant Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 04/24] directfb: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 05/24] erlang-goldrush: " Julien Floret
2016-06-30  8:12   ` Thomas Petazzoni
2016-06-29 13:46 ` [Buildroot] [PATCH 06/24] jsmin: " Julien Floret
2016-06-29 13:56   ` Thomas Petazzoni [this message]
2016-06-29 16:14     ` Peter Korsgaard
2016-06-29 13:46 ` [Buildroot] [PATCH 07/24] libatomic_ops: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 08/24] libconfuse: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 09/24] libpthread-stubs: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 10/24] libsemanage: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 11/24] libsodium: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 12/24] lzip: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 13/24] pax-utils: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 14/24] perl-file-util: " Julien Floret
2016-07-03 15:22   ` Carlos Santos
2016-07-03 15:49     ` Thomas Petazzoni
2016-06-29 13:46 ` [Buildroot] [PATCH 15/24] python-jinja2: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 16/24] python-mako: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 17/24] sdl_image: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 18/24] setools: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 19/24] xutil_util-macros: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 20/24] bzip2: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 21/24] python-markupsafe: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 22/24] sdl: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 23/24] sqlite: " Julien Floret
2016-06-29 13:46 ` [Buildroot] [PATCH 24/24] ustr: " Julien Floret
2016-06-29 13:52 ` [Buildroot] [PATCH 00/24] Drop unused host packages Thomas Petazzoni
2016-06-29 14:00   ` Julien Floret
2016-06-29 14:11     ` Thomas Petazzoni
2016-06-29 14:30       ` Julien Floret
2016-06-29 14:43         ` Thomas Petazzoni
2016-06-29 21:53           ` Ezequiel Garcia
2016-06-30  1:08             ` Henrique Marks
2016-06-30 13:01             ` Julien Floret
2016-07-02 10:05               ` Arnout Vandecappelle
2016-07-02 10:18   ` Arnout Vandecappelle
2016-07-02 10:33     ` Thomas Petazzoni
2016-07-02 11:30       ` Peter Korsgaard
2016-07-02 14:08         ` Julien Floret
2016-07-02 14:43           ` Arnout Vandecappelle
2016-07-02 19:15             ` Julien Floret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629155653.326794ba@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox