Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8] openblas: new package
Date: Fri, 1 Jul 2016 16:29:54 +0200	[thread overview]
Message-ID: <20160701162954.43c8da69@free-electrons.com> (raw)
In-Reply-To: <1467017090-582-1-git-send-email-Vincent.Riera@imgtec.com>

Hello,

On Mon, 27 Jun 2016 09:44:50 +0100, Vicente Olivert Riera wrote:
> OpenBLAS is optimised for specific CPU models, which don't fully match
> with the GCC code generation options. Therefore, we can't automatically
> select BR2_PACKAGE_OPENBLAS_TARGET based on the CPU choice. Instead, let
> the user select the TARGET name, but offer a sensible default. Other
> possible solutions were deemed too complicated: adding choice options in
> the ambiguous cases, or only making the option user-visible when there
> is ambiguity.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Changes v7 -> v8:
>  - Rename BR2_PACKAGE_OPENBLAS_TARGET to BR2_PACKAGE_OPENBLAS_DEFAULT_TARGET
>    and make it a blind option. Make BR2_PACKAGE_OPENBLAS_ARCH_SUPPORTS
>    depend on BR2_PACKAGE_OPENBLAS_DEFAULT_TARGET != "", this way the package
>    will not be available for architectures which don't have any matching
>    OpenBLAS target. This will avoid future build failures. Finally add
>    BR2_PACKAGE_OPENBLAS_TARGET option, which will depend on the package
>    being selected, to let the user change the default OpenBLAS target. (Arnout)
>  - Initialise OpenBLAS make options to TARGET_CONFIGURE_OPTS. This way
>    TARGET_CONFIGURE_OPTS is also used in the install phases. (Arnout)

Applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-07-01 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27  8:44 [Buildroot] [PATCH v8] openblas: new package Vicente Olivert Riera
2016-07-01 14:29 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160701162954.43c8da69@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox