Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/13] package/gcc: use BR2_USE_WCHAR to set gcc libquadmath option
Date: Fri, 1 Jul 2016 17:30:33 +0200	[thread overview]
Message-ID: <20160701173033.40f03bf4@free-electrons.com> (raw)
In-Reply-To: <1467040287-39390-1-git-send-email-Vincent.Riera@imgtec.com>

Hello,

On Mon, 27 Jun 2016 16:11:15 +0100, Vicente Olivert Riera wrote:
> From: Samuel Martin <s.martin49@gmail.com>
> 
> BR2_TOOLCHAIN_BUILDROOT_WCHAR is only defined when uclibc is selected, whereas
> BR2_USE_WCHAR is always defined.
> 
> So, use BR2_USE_WCHAR to drive the gcc libquadmath option.
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

I've applied, after doing some tweaks, see below.

> ---
>  package/gcc/gcc.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
> index 46f05ff..88d2bc2 100644
> --- a/package/gcc/gcc.mk
> +++ b/package/gcc/gcc.mk
> @@ -107,7 +107,7 @@ HOST_GCC_COMMON_CONF_OPTS += --disable-libitm
>  endif
>  
>  # gcc 4.6.x quadmath requires wchar

I've updated this commit, because the requirement on wchar doesn't
apply just to gcc 4.6. It applies *since* 4.6, because that's when
libquadmath was introduced.

> -ifneq ($(BR2_TOOLCHAIN_BUILDROOT_WCHAR),y)
> +ifneq ($(BR2_USE_WCHAR),y)

And I've inverted the condition to use positive logic:

ifeq ($(BR2_USE_WCHAR),)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-07-01 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 15:11 [Buildroot] [PATCH 01/13] package/gcc: use BR2_USE_WCHAR to set gcc libquadmath option Vicente Olivert Riera
2016-06-27 15:11 ` [Buildroot] [PATCH 02/13] package/gcc: fix fortran support Vicente Olivert Riera
2016-06-27 15:11 ` [Buildroot] [PATCH 03/13] package/gcc: wrap gfortran Vicente Olivert Riera
2016-06-27 15:11 ` [Buildroot] [PATCH 04/13] pkg-cmake.mk: export the fortran compiler path in the CMake toolchain file Vicente Olivert Riera
2016-06-27 15:11 ` [Buildroot] [PATCH 05/13] toolchain: add hidden symbol for fortran support in the toolchain Vicente Olivert Riera
2016-07-01 15:30 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160701173033.40f03bf4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox