From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sat, 2 Jul 2016 17:43:37 +0200 Subject: [Buildroot] [PATCH 1/3] Move the host-pkgconf dependency from host-cmake to pkg-cmake In-Reply-To: References: <1467388410-28135-1-git-send-email-luca@lucaceresoli.net> <1467388410-28135-2-git-send-email-luca@lucaceresoli.net> <14747128-2dd0-efb6-6c4c-faf744e8899a@mind.be> <20160702144455.GN22343@free.fr> Message-ID: <20160702154337.GP22343@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2016-07-02 16:52 +0200, Arnout Vandecappelle spake thusly: > On 02-07-16 16:44, Yann E. MORIN wrote: > > However, because the culprit for causing the dependency to host-pkgconf > > is cmake itslef, and not a cmake-based package, I would suggest that we > > do not consider this a hack, but the reality. > > Isn't the problem that package foo uses FindBar from cmake, which uses > pkg-config to find the package? For me, the burden of depending on host-pkgconf > is on package foo in that case. I don't agree. ;-) The use of pkg-config is an internal detail of the CMake modules, of which the package should have no knowledge. > That said, this hack really simplifies things so let's indeed keep it. On which I'll close the discussion. Thanks! :-) > Actually, why don't we just always build host-pkgconf? On my machine 'make > host-pkgconf' takes 6.5 seconds, of which 4.7 seconds are parsing the makefiles. > Can we afford the cost of 1.5 seconds of build time and 844K of build size? If we decide so, then we should move this non-hack into the generic-package infra, so that it benefits all packages at once, not only cmake-based packages. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'