From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] package/pulseaudio: add WebRTC optional dependency
Date: Mon, 4 Jul 2016 00:54:46 +0200 [thread overview]
Message-ID: <20160703225446.GG3482@free.fr> (raw)
In-Reply-To: <1467585172-10299-3-git-send-email-romain.naour@gmail.com>
Romain, All,
On 2016-07-04 00:32 +0200, Romain Naour spake thusly:
> WebRTC is an optional pulseaudio dependency which require C++11
> support in the toolchain.
This change has nothing to do with the c++11 support, has it?
> Also the autotool script provide
> --enable/--disable option for this support, so use them in
> pulseaudio.mk.
I would rephrase that commit log such as;
package/pulseaudio: explicitly enable/disable WebRTC support
Currently, pulseaudio optionally depends on webrtc if it is enabled.
However, it is never explcitly enabled or disabled, although
pulseaudio's ./configure has --enable/disable-webrtc-aec.
Forcibly enable/disable webrtc support usign those options.
Signed-off-by: You
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
(You can keep my reviewd-by tag when you respin)
Regards,
Yann E. MORIN.
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/pulseaudio/pulseaudio.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/pulseaudio/pulseaudio.mk b/package/pulseaudio/pulseaudio.mk
> index bc95d91..9ef11bc 100644
> --- a/package/pulseaudio/pulseaudio.mk
> +++ b/package/pulseaudio/pulseaudio.mk
> @@ -34,7 +34,6 @@ PULSEAUDIO_DEPENDENCIES = \
> $(if $(BR2_PACKAGE_BLUEZ_UTILS),bluez_utils) \
> $(if $(BR2_PACKAGE_OPENSSL),openssl) \
> $(if $(BR2_PACKAGE_FFTW),fftw) \
> - $(if $(BR2_PACKAGE_WEBRTC_AUDIO_PROCESSING),webrtc-audio-processing) \
> $(if $(BR2_PACKAGE_SYSTEMD),systemd)
>
> ifeq ($(BR2_PACKAGE_GDBM),y)
> @@ -88,6 +87,13 @@ else
> PULSEAUDIO_CONF_OPTS += --disable-udev
> endif
>
> +ifeq ($(BR2_PACKAGE_WEBRTC_AUDIO_PROCESSING),y)
> +PULSEAUDIO_CONF_OPTS += --enable-webrtc-aec
> +PULSEAUDIO_DEPENDENCIES += webrtc-audio-processing
> +else
> +PULSEAUDIO_CONF_OPTS += --disable-webrtc-aec
> +endif
> +
> ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
> # The optional webrtc echo canceller is written in C++, causing auto* to want
> # to link module-echo-cancel.so with CXX even if webrtc ISN'T used.
> --
> 2.5.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-07-03 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 22:32 [Buildroot] [PATCH 1/4] package/webrtc-audio-processing: needs gcc >= 4.8 Romain Naour
2016-07-03 22:32 ` [Buildroot] [PATCH 2/4] package/pulseaudio: allow to build without C++11 support Romain Naour
2016-07-03 22:50 ` Yann E. MORIN
2016-07-03 22:32 ` [Buildroot] [PATCH 3/4] package/pulseaudio: add WebRTC optional dependency Romain Naour
2016-07-03 22:54 ` Yann E. MORIN [this message]
2016-07-03 22:32 ` [Buildroot] [PATCH 4/4] package/puseaudio: fix typo Romain Naour
2016-07-03 22:39 ` Yann E. MORIN
2016-07-03 22:43 ` [Buildroot] [PATCH 1/4] package/webrtc-audio-processing: needs gcc >= 4.8 Yann E. MORIN
2016-07-03 23:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160703225446.GG3482@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox