From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] qemu: add qemu-system-run make target
Date: Mon, 4 Jul 2016 00:29:23 +0200 [thread overview]
Message-ID: <20160704002923.288baea0@free-electrons.com> (raw)
In-Reply-To: <1462348079-7631-4-git-send-email-simonn.maes@gmail.com>
Hello,
On Wed, 4 May 2016 09:47:57 +0200, Simon Maes wrote:
> Additional configuration for qemu package:
> - Save qemu commandline arguments to run qemu directly using
> 'make qemu-system-run'.
>
> Signed-off-by: Simon Maes <simonn.maes@gmail.com>
> ---
> package/qemu/Config.in.host | 7 +++++++
> package/qemu/qemu.mk | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
> index c86768f..8c07e71 100644
> --- a/package/qemu/Config.in.host
> +++ b/package/qemu/Config.in.host
> @@ -88,4 +88,11 @@ config BR2_PACKAGE_HOST_QEMU_STRIP_BINARY
>
> endif # BR2_PACKAGE_HOST_QEMU_HAS_EMULS
>
> +config BR2_PACKAGE_HOST_QEMU_SYSTEM_ARGS
> + string "qemu-system command arguments"
> + depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE
> + help
> + Arguments to be used for your target host-qemu-system to run
> + via "make qemu-system-run".
> +
> endif # BR2_PACKAGE_HOST_QEMU
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 1910dbd..4de32b9 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -151,6 +151,15 @@ $(eval $(host-generic-package))
> # variable used by other packages
> QEMU_USER = $(HOST_DIR)/usr/bin/qemu-$(HOST_QEMU_ARCH)
>
> +ifeq ($(BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE),y)
> +QEMU_SYSTEM = $(HOST_DIR)/usr/bin/qemu-system-$(HOST_QEMU_ARCH)
> +
> +.PHONY: qemu-system-run
> +qemu-system-run:
> + $(QEMU_SYSTEM) $(call qstrip,$(BR2_PACKAGE_HOST_QEMU_SYSTEM_ARGS))
> +endif
We feel this is a bit "too special", and doesn't bring a lot of value
compared to just having a shell script next to Buildroot. So for now,
we prefer to keep this out of Buildroot.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-03 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 7:47 [Buildroot] [PATCH 1/6] qemu: add support for host-qemu-system Simon Maes
2016-05-04 7:47 ` [Buildroot] [PATCH 2/6] qemu: make qemu and host-qemu packages' version (separately) configurable Simon Maes
2016-05-07 19:01 ` Arnout Vandecappelle
2016-07-03 22:26 ` Thomas Petazzoni
2016-05-04 7:47 ` [Buildroot] [PATCH 3/6] qemu: code cleanup - (mostly) wrapping lines at 80 characters Simon Maes
2016-07-03 22:28 ` Thomas Petazzoni
2016-05-04 7:47 ` [Buildroot] [PATCH 4/6] qemu: add qemu-system-run make target Simon Maes
2016-07-03 22:29 ` Thomas Petazzoni [this message]
2016-05-04 7:47 ` [Buildroot] [PATCH 5/6] vde2: enable building host package Simon Maes
2016-07-03 22:30 ` Thomas Petazzoni
2016-05-04 7:47 ` [Buildroot] [PATCH 6/6] qemu: add support for vde2 Simon Maes
2016-07-03 22:31 ` Thomas Petazzoni
2016-05-04 22:34 ` [Buildroot] [PATCH 1/6] qemu: add support for host-qemu-system Arnout Vandecappelle
2016-07-03 22:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704002923.288baea0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox