Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Package nfs-utils: Start/stop daemons consistently
Date: Mon, 4 Jul 2016 11:42:29 +0200	[thread overview]
Message-ID: <20160704114229.5f5e9ea8@free-electrons.com> (raw)
In-Reply-To: <1467564419-21313-1-git-send-email-maxime.hadjinlian@gmail.com>

Hello,

On Sun,  3 Jul 2016 18:46:58 +0200, Maxime Hadjinlian wrote:
> From: universe II <universeii@gmx.de>
> 
> Changed init script to start and stop all nfs daemons
> in a consistent way. Using the same kill command,
> start/stop the daemon, printout OK or FAIL and touch
> or deleted necessary files.
> 
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> [Maxime:
>    - Make it really consistent to stop the daemons as pointed out by Yann E. Morin
>    - Remove the -9]
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/nfs-utils/S60nfs | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Both applied, with minor tweaks. Regarding the second patch, I really
wasn't sure since we don't have written rules about indentation in our
init scripts, it's the kind of things that tends to get changed in one
direction, and then in the other direction a few months later. But
anyway, since the patch was done, I applied it.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-07-04  9:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 16:46 [Buildroot] [PATCH 1/2] Package nfs-utils: Start/stop daemons consistently Maxime Hadjinlian
2016-07-03 16:46 ` [Buildroot] [PATCH 2/2] package/nfs-utils: Fix indent Maxime Hadjinlian
2016-07-03 16:54   ` Thomas Petazzoni
2016-07-03 16:53 ` [Buildroot] [PATCH 1/2] Package nfs-utils: Start/stop daemons consistently Thomas Petazzoni
2016-07-06 16:53   ` Andreas Ehmanns
2016-07-04  9:42 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704114229.5f5e9ea8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox