From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Mon, 4 Jul 2016 19:13:52 +0200
Subject: [Buildroot] [PATCH 06/24 v2] package/systemd: disabling tty1
 getty is a post-install hook
In-Reply-To: <e4252a68-df6a-6b49-5f6a-01d3a3c18d40@gmail.com>
References: <cover.1466622379.git.yann.morin.1998@free.fr>
 <fe81b5c13c44ebd66ef69fd8bc76e6e8acb14725.1466622379.git.yann.morin.1998@free.fr>
 <e4252a68-df6a-6b49-5f6a-01d3a3c18d40@gmail.com>
Message-ID: <20160704171352.GH3549@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Romain, All,

On 2016-07-03 10:37 +0200, Romain Naour spake thusly:
> Le 22/06/2016 ? 21:07, Yann E. MORIN a ?crit :
> > Currently, we disable the getty on tty1 as a "init" step. It looks
> > better like it is a post-install hook.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  package/systemd/systemd.mk | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> > index c0503ae..7e8fc0b 100644
> > --- a/package/systemd/systemd.mk
> > +++ b/package/systemd/systemd.mk
> > @@ -211,10 +211,15 @@ define SYSTEMD_INSTALL_MACHINEID_HOOK
> >  	touch $(TARGET_DIR)/etc/machine-id
> >  endef
> >  
> > +define SYSTEMD_DISABLE_SERVICE_TTY1_HOOK
> > +	rm -f $(TARGET_DIR)/etc/systemd/system/getty.target.wants/getty at tty1.service
> > +endef
> > +
> >  SYSTEMD_POST_INSTALL_TARGET_HOOKS += \
> >  	SYSTEMD_INSTALL_INIT_HOOK \
> >  	SYSTEMD_INSTALL_MACHINEID_HOOK \
> > -	SYSTEMD_INSTALL_RESOLVCONF_HOOK
> > +	SYSTEMD_INSTALL_RESOLVCONF_HOOK \
> > +	SYSTEMD_DISABLE_SERVICE_TTY1_HOOK
> 
> It would be great to keep alphabetical order :)

Well, 'SERVICE' comes after 'RESOLVCONF', no?

OK, 'DISABLE' comes before 'INSTALL'... ;-)

I can switch, yes.

> Otherwise:
>   Reviewed-by: Romain Naour <romain.naour@gmail.com>

OK, thanks! :-)

Regards,
Yann E. MORIN.

> Best regards,
> Romain
> 
> 
> >  
> >  define SYSTEMD_USERS
> >  	systemd-journal -1 systemd-journal -1 * /var/log/journal - - Journal
> > @@ -228,10 +233,6 @@ define SYSTEMD_USERS
> >  	- - input -1 * - - - Input device group
> >  endef
> >  
> > -define SYSTEMD_DISABLE_SERVICE_TTY1
> > -	rm -f $(TARGET_DIR)/etc/systemd/system/getty.target.wants/getty at tty1.service
> > -endef
> > -
> >  ifneq ($(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT)),)
> >  # systemd needs getty.service for VTs and serial-getty.service for serial ttys
> >  # also patch the file to use the correct baud-rate, the default baudrate is 115200 so look for that
> > @@ -252,7 +253,6 @@ endef
> >  endif
> >  
> >  define SYSTEMD_INSTALL_INIT_SYSTEMD
> > -	$(SYSTEMD_DISABLE_SERVICE_TTY1)
> >  	$(SYSTEMD_INSTALL_SERVICE_TTY)
> >  	$(SYSTEMD_INSTALL_SERVICE_NETWORK)
> >  	$(SYSTEMD_INSTALL_SERVICE_TIMESYNC)
> > 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'