Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] acpica: new package
Date: Tue, 5 Jul 2016 10:16:53 +0200	[thread overview]
Message-ID: <20160705101653.365090c4@free-electrons.com> (raw)
In-Reply-To: <20160703104535.10401-1-nunes.erico@gmail.com>

Hello,

On Sun,  3 Jul 2016 12:45:35 +0200, Erico Nunes wrote:

> +ACPICA_VERSION = 20160527
> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
> +ACPICA_SITE = https://acpica.org/sites/acpica/files
> +ACPICA_LICENSE = BSD-3c or GPLv2
> +ACPICA_LICENSE_FILES = source/include/acpi.h
> +ACPICA_DEPENDENCIES = host-bison host-flex
> +
> +define ACPICA_BUILD_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \

The HARDWARE_NAME variable is pretty useless, it's only used to echo
some messages. But I've kept it since it's used, and sent a patch
upstream to get rid of it (https://github.com/acpica/acpica/pull/152).

> +define ACPICA_INSTALL_TARGET_CMDS
> +	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
> +		INSTALLFLAGS=-m555 install

555 is a bit unusual for binaries, we prefer to use 755. I've changed
it and applied your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-07-05  8:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 10:45 [Buildroot] [PATCH v2 1/1] acpica: new package Erico Nunes
2016-07-03 13:45 ` Romain Naour
2016-07-04  7:33   ` Arnout Vandecappelle
2016-07-04 13:45   ` Erico Nunes
2016-07-04 13:52     ` Romain Naour
2016-07-04 14:04     ` Andy Shevchenko
2016-07-04 13:33 ` Andy Shevchenko
2016-07-04 13:41   ` Erico Nunes
2016-07-05  8:16 ` Thomas Petazzoni [this message]
2016-07-05 17:15 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705101653.365090c4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox