Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] hostapd: default hostapd.conf on target
Date: Tue, 5 Jul 2016 10:48:24 +0200	[thread overview]
Message-ID: <20160705104824.02c1e322@free-electrons.com> (raw)
In-Reply-To: <1467708149.3144.46.camel@synopsys.com>

Hello,

On Tue, 5 Jul 2016 08:43:39 +0000, Alexey Brodkin wrote:

> I'm wondering if there's a reason default/example hostapd.conf is not installed on target?
> IMHO it would be pretty convenient to have that config as a starting point.
> Otherwise user has to create it manually from scratch.
> 
> Technically this is just a matter of:
> ------------------------>8-------------------------  
> diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> index dca07c1..40a21ff 100644
> --- a/package/hostapd/hostapd.mk
> +++ b/package/hostapd/hostapd.mk
> @@ -85,7 +85,9 @@ define HOSTAPD_INSTALL_TARGET_CMDS
> ????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd \
> ????????????????$(TARGET_DIR)/usr/sbin/hostapd
> ????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
> -???????????????$(TARGET_DIR)/usr/bin/hostapd_cli
> +???????????????$(TARGET_DIR)/usr/bin/hostapd_cli \
> +???????$(INSTALL) -m 0644 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd/hostapd.conf \
> +???????????????$(TARGET_DIR)/etc/hostapd.conf
> ?endef
> ?
> ?$(eval $(generic-package))
> ------------------------>8-------------------------  

Thanks for your proposal, looks good to me. Gustavo, what do you think?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-07-05  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  8:43 [Buildroot] hostapd: default hostapd.conf on target Alexey Brodkin
2016-07-05  8:48 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705104824.02c1e322@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox